author | Junio C Hamano <gitster@pobox.com> | |
Tue, 20 Jul 2010 18:29:30 +0000 (11:29 -0700) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Tue, 20 Jul 2010 18:29:30 +0000 (11:29 -0700) |
* maint:
t/README: clarify test_must_fail description
Check size of path buffer before writing into it
Conflicts:
t/README
t/README: clarify test_must_fail description
Check size of path buffer before writing into it
Conflicts:
t/README
setup.c | patch | blob | history | |
t/README | patch | blob | history |
index 87c21f02e0e3bedb42305bbfe2b4223885d4250f..276916052795c5ffa872b57a7e6723edc71dfdc4 100644 (file)
--- a/setup.c
+++ b/setup.c
char path[PATH_MAX];
size_t len = strlen(suspect);
+ if (PATH_MAX <= len + strlen("/objects"))
+ die("Too long path: %.*s", 60, suspect);
strcpy(path, suspect);
if (getenv(DB_ENVIRONMENT)) {
if (access(getenv(DB_ENVIRONMENT), X_OK))
diff --git a/t/README b/t/README
index b906ceb4766a283ae6b22bd037f9e1619feb12d1..a5901424388b9cfb525b7bdbfd6d5afda3c9e014 100644 (file)
--- a/t/README
+++ b/t/README
- test_must_fail <git-command>
Run a git command and ensure it fails in a controlled way. Use
- this instead of "! <git-command>" to fail when git commands
- segfault.
+ this instead of "! <git-command>". When git-command dies due to a
+ segfault, test_must_fail diagnoses it as an error; "! <git-command>"
+ treats it as just another expected failure, which would let such a
+ bug go unnoticed.
- test_might_fail <git-command>