Code

Fix the "close before dup" bug in clone-pack too
authorLinus Torvalds <torvalds@g5.osdl.org>
Thu, 14 Jul 2005 03:05:17 +0000 (20:05 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Thu, 14 Jul 2005 03:05:17 +0000 (20:05 -0700)
Same issue as git-fetch-pack.

clone-pack.c

index 8f5209cfd5bfa5e2cc97333a33432b747f90d96d..252fb80efd55a4cc4fa679411c4570093500f4ad 100644 (file)
@@ -152,9 +152,9 @@ static int clone_pack(int fd[2], int nr_match, char **match)
        if (pid < 0)
                die("git-clone-pack: unable to fork off git-unpack-objects");
        if (!pid) {
-               close(fd[1]);
                dup2(fd[0], 0);
                close(fd[0]);
+               close(fd[1]);
                execlp("git-unpack-objects", "git-unpack-objects",
                        quiet ? "-q" : NULL, NULL);
                die("git-unpack-objects exec failed");