no need to initialize result ptr of getaddrinfo

diff --git a/src/daemon/common.c b/src/daemon/common.c
index b3bc753286fd569f504e7db820ca75c68fd51a00..7bbace76e0a817b1f351f99c9099b2f3668787ba 100644 (file)
--- a/src/daemon/common.c
+++ b/src/daemon/common.c
@@ -1524,8 +1524,6 @@ int service_name_to_port_number (const char *service_name)
        if (service_name == NULL)
                return (-1);
 
-       ai_list = NULL;
-
        struct addrinfo ai_hints = {
                .ai_family = AF_UNSPEC
        };

diff --git a/src/libcollectdclient/client.c b/src/libcollectdclient/client.c
index fea9360ede7083bf2d0897e512d7af4f60a7a3e9..cd333cc3ced478baf8c445a623e4dda114bbca43 100644 (file)
--- a/src/libcollectdclient/client.c
+++ b/src/libcollectdclient/client.c
@@ -471,8 +471,6 @@ static int lcc_open_netsocket (lcc_connection_t *c, /* {{{ */
     }
   }
 
-  ai_res = NULL;
-
   struct addrinfo ai_hints = {
     .ai_family = AF_UNSPEC,
     .ai_flags = AI_ADDRCONFIG,

diff --git a/src/libcollectdclient/network.c b/src/libcollectdclient/network.c
index afbee6e8ea5b2e4231040aac59177f9b59b6cfdf..ee5af3b5183db715f6a4369784388b9e5a875e95 100644 (file)
--- a/src/libcollectdclient/network.c
+++ b/src/libcollectdclient/network.c
@@ -119,7 +119,7 @@ static void int_server_destroy (lcc_server_t *srv) /* {{{ */
 
 static int server_open_socket (lcc_server_t *srv) /* {{{ */
 {
-  struct addrinfo *ai_list = NULL;
+  struct addrinfo *ai_list;
   struct addrinfo *ai_ptr;
   int status;
 

diff --git a/src/memcached.c b/src/memcached.c
index c0c9e70c5abff946704154d2796fa24e2484d551..46155e7e455eea81c5d9e8d69f4ccbb69655bace 100644 (file)
--- a/src/memcached.c
+++ b/src/memcached.c
@@ -108,8 +108,6 @@ static int memcached_connect_inet (memcached_t *st)
   host = (st->host != NULL) ? st->host : MEMCACHED_DEF_HOST;
   port = (st->port != NULL) ? st->port : MEMCACHED_DEF_PORT;
 
-  ai_list = NULL;
-
   struct addrinfo ai_hints = {
     .ai_family = AF_UNSPEC,
     .ai_flags = AI_ADDRCONFIG,

diff --git a/src/modbus.c b/src/modbus.c
index a2150600902bb789ccae2d9437a66ec4e0cdecfe..ec429698bda23d1c7ca62c031b3099c809989fb9 100644 (file)
--- a/src/modbus.c
+++ b/src/modbus.c
@@ -823,8 +823,6 @@ static int mb_config_set_host_address (mb_host_t *host, /* {{{ */
   if ((host == NULL) || (address == NULL))
     return (EINVAL);
 
-  ai_list = NULL;
-
   struct addrinfo  ai_hints = {
     /* XXX: libmodbus can only handle IPv4 addresses. */
     .ai_family = AF_INET,

diff --git a/src/network.c b/src/network.c
index 11c39a7815bb88d1749eed94cbc1fb215388a61d..4ce3f5f04b638eb38ec11febc8782681a374f1c2 100644 (file)
--- a/src/network.c
+++ b/src/network.c
@@ -2139,7 +2139,7 @@ static int sockent_client_connect (sockent_t *se) /* {{{ */
        static c_complain_t complaint = C_COMPLAIN_INIT_STATIC;
 
        struct sockent_client *client;
-       struct addrinfo *ai_list = NULL, *ai_ptr;
+       struct addrinfo *ai_list, *ai_ptr;
        int status;
        _Bool reconnect = 0;
        cdtime_t now;

diff --git a/src/olsrd.c b/src/olsrd.c
index 976793fe38fbc86856346df85050aa0f56be0104..ac47811ceb4734aae3178cd43eac65c4b03a70a3 100644 (file)
--- a/src/olsrd.c
+++ b/src/olsrd.c
@@ -154,8 +154,6 @@ static FILE *olsrd_connect (void) /* {{{ */
 
   FILE *fh;
 
-  ai_list = NULL;
-
   struct addrinfo ai_hints = {
     .ai_family   = PF_UNSPEC,
     .ai_flags    = AI_ADDRCONFIG,

diff --git a/src/pinba.c b/src/pinba.c
index 6a4ebfcd24cc45e18a2838cd979dab993683cc6e..66170bf7c93b58e9b3dd85ef200d31d65ed83515 100644 (file)
--- a/src/pinba.c
+++ b/src/pinba.c
@@ -360,8 +360,6 @@ static pinba_socket_t *pinba_socket_open (const char *node, /* {{{ */
   if (service == NULL)
     service = PINBA_DEFAULT_SERVICE;
 
-  ai_list = NULL;
-
   struct addrinfo  ai_hints = {
     .ai_family = AF_UNSPEC,
     .ai_flags = AI_PASSIVE,

diff --git a/src/statsd.c b/src/statsd.c
index 285486d88cee53777c5289db1cd0e3cec632d1f8..8acd9fd21262284e8fe222c3eea3f6b30fbab156 100644 (file)
--- a/src/statsd.c
+++ b/src/statsd.c
@@ -500,7 +500,7 @@ static int statsd_network_init (struct pollfd **ret_fds, /* {{{ */
   struct pollfd *fds = NULL;
   size_t fds_num = 0;
 
-  struct addrinfo *ai_list = NULL;
+  struct addrinfo *ai_list;
   struct addrinfo *ai_ptr;
   int status;
 

diff --git a/src/write_graphite.c b/src/write_graphite.c
index efdd4d8a23206c6ab3ddae927f6d22422607e09b..f890b97119ed4ef1619101ece18b7391e33bfc7a 100644 (file)
--- a/src/write_graphite.c
+++ b/src/write_graphite.c
@@ -220,8 +220,6 @@ static int wg_callback_init (struct wg_callback *cb)
     else
         ai_hints.ai_socktype = SOCK_DGRAM;
 
-    ai_list = NULL;
-
     status = getaddrinfo (cb->node, cb->service, &ai_hints, &ai_list);
     if (status != 0)
     {

diff --git a/src/write_tsdb.c b/src/write_tsdb.c
index fe418cf9e7d616f402b6defaad8d3bcd8482ea04..401e87539a4c58d531cd47c27be375d738a40620 100644 (file)
--- a/src/write_tsdb.c
+++ b/src/write_tsdb.c
@@ -165,8 +165,6 @@ static int wt_callback_init(struct wt_callback *cb)
     if (cb->sock_fd > 0)
         return 0;
 
-    ai_list = NULL;
-
     struct addrinfo ai_hints = {
         .ai_family = AF_UNSPEC,
         .ai_flags = AI_ADDRCONFIG,