* Added basic support for tagging new objects

  There are a set of objects that cannot be handeled easily and
  have to be fixed:

  - fai (because of subentries)
  - addressbook (because of subentries)

  Additionaly create_missing_trees has to be adapted to write the tags of
  the parent node, too.

* Updated TODO file

git-svn-id: https://oss.gonicus.de/repositories/gosa/trunk@3205 594d385d-05f5-0310-b6e9-bd551577e9d8

diff --git a/TODO b/TODO
index cb68e5efa4754cd7124aba48c07e61897ee2c2f6..c0eb1877ee2d2370f77d13b6cc88715c148b8a73 100644 (file)
--- a/TODO
+++ b/TODO
@@ -1,15 +1,8 @@
 Target for 2.4.1:
 =================
 
-* Sanity check for workstations/servers: repository server == self?
-
-* Can't remove phoneAccounts...
-
 * Explaination of several FIXME's. Group removal, etc.
 
-* peopleou, groupou, fai, etc. as department? Please check!
-  Check during login/setup?
-
 * saveFilter added, please use!
 
 * Added functions normalizePreg and normalizeLdap. Please use where needed!
@@ -17,14 +10,11 @@ Target for 2.4.1:
 * generatePasteIcon added, please use!
 
 * Create a status-bar/-display for FAI installations 
-  (Use notes from 0.5.12.2005)
 
 * Add online help (english/german)
+  Document how to generate it, generate it and check it in
 
-* Check virenschleuder/Winstations in Admin->Systems 
-  LDAP-Error: Cannot modify object class (structural object class modification from 'person' to 'inetOrgPerson' not allowed)
-
-* Test DNS plugin. Add some more checks 
+* Fix DNS plugin. Add some more checks 
 
 * Enhance the export xls to export the whole three with a maximum of attributes in each sheet ( OpenSides )
 
@@ -38,6 +28,14 @@ Target for 2.4.1:
 
 * Auto-Resize for subdialogs
 
+* Fix create_missing_trees to gererate tags if needed, too
+
+* Fix fai objects to generate tags if needed (sub objects, phone me...)
+
+* Fix Phone book to generate tags if needed
+
+* Remove the refresh button from faiPackageNew (the second one)
+
 
 Target for 2.5:
 ===============

diff --git a/plugins/admin/applications/tabs_application.inc b/plugins/admin/applications/tabs_application.inc
index d9c78dbd5867d2352e87c3079a576aeda186d33e..4d8eb2824acc76babc9a5aefb3f47946463b7914 100644 (file)
--- a/plugins/admin/applications/tabs_application.inc
+++ b/plugins/admin/applications/tabs_application.inc
@@ -48,6 +48,9 @@ class apptabs extends tabs
     }
 
     tabs::save();
+
+    /* Fix tagging if needed */
+    $baseobject->handle_object_tagging();
   }
 
 }

diff --git a/plugins/admin/fai/tabsHook.inc b/plugins/admin/fai/tabsHook.inc
index c16313fe22f23de96f3554959d8533c68e7f7293..c097e7afe24d6d4587452d266466c1ea37c18fd2 100644 (file)
--- a/plugins/admin/fai/tabsHook.inc
+++ b/plugins/admin/fai/tabsHook.inc
@@ -39,6 +39,9 @@ class tabsHook extends tabs
        $this->dn= $new_dn;
 
        tabs::save(TRUE);
+
+       /* Fix tagging if needed */
+       $baseobject->handle_object_tagging();
   }
 
 }

diff --git a/plugins/admin/fai/tabsPackage.inc b/plugins/admin/fai/tabsPackage.inc
index 21b2fb48bd299c8d753b0d6d844fff0d1d55c19a..44b99d69ff947231d4c03fcf58a5ecfb22d1a362 100644 (file)
--- a/plugins/admin/fai/tabsPackage.inc
+++ b/plugins/admin/fai/tabsPackage.inc
@@ -38,6 +38,9 @@ class tabsPackage extends tabs
        $this->dn= $new_dn;
 
        tabs::save(TRUE);
+
+       /* Fix tagging if needed */
+       $baseobject->handle_object_tagging();
   }
 
 }

diff --git a/plugins/admin/fai/tabsPartition.inc b/plugins/admin/fai/tabsPartition.inc
index c18779abe68b661eecf0b171680ee804a4efba94..5c44b82a721b98f3f082b92479f17bb90b6635d1 100644 (file)
--- a/plugins/admin/fai/tabsPartition.inc
+++ b/plugins/admin/fai/tabsPartition.inc
@@ -39,6 +39,9 @@ class tabsPartition extends tabs
        $this->dn= $new_dn;
 
        tabs::save(TRUE);
+
+       /* Fix tagging if needed */
+       $baseobject->handle_object_tagging();
   }
 
 }

diff --git a/plugins/admin/fai/tabsProfile.inc b/plugins/admin/fai/tabsProfile.inc
index 3131a1dbe63c4c791e5802e7e86107e11b2c3ab0..a63ac91660b92a468dbe44b9d266220bc940446a 100644 (file)
--- a/plugins/admin/fai/tabsProfile.inc
+++ b/plugins/admin/fai/tabsProfile.inc
@@ -39,6 +39,9 @@ class tabsProfile extends tabs
        $this->dn= $new_dn;
 
        tabs::save(TRUE);
+
+       /* Fix tagging if needed */
+       $baseobject->handle_object_tagging();
   }
 
 }

diff --git a/plugins/admin/fai/tabsScript.inc b/plugins/admin/fai/tabsScript.inc
index 22a34d2c9690ceac786eca76a8caa68a85773dc6..177e88a8e3bb33ede7d8fa3129dc707cb3876f44 100644 (file)
--- a/plugins/admin/fai/tabsScript.inc
+++ b/plugins/admin/fai/tabsScript.inc
@@ -39,6 +39,9 @@ class tabsScript extends tabs
        $this->dn= $new_dn;
 
        tabs::save(TRUE);
+
+       /* Fix tagging if needed */
+       $baseobject->handle_object_tagging();
   }
 
 }

diff --git a/plugins/admin/fai/tabsTemplate.inc b/plugins/admin/fai/tabsTemplate.inc
index 28851dbaf6f0b45d6fcced868a68ba6fa0bfe052..142a4a5811e316059e87be5e5610c6d9d1d14995 100644 (file)
--- a/plugins/admin/fai/tabsTemplate.inc
+++ b/plugins/admin/fai/tabsTemplate.inc
@@ -39,6 +39,9 @@ class tabsTemplate extends tabs
        $this->dn= $new_dn;
 
        tabs::save(TRUE);
+
+       /* Fix tagging if needed */
+       $baseobject->handle_object_tagging();
   }
 
 }

diff --git a/plugins/admin/fai/tabsVariable.inc b/plugins/admin/fai/tabsVariable.inc
index c41a7f78c307c4fe012b238f00a7df70b3df376b..e2b59917e7923a19db5c0f751986eff179926a53 100644 (file)
--- a/plugins/admin/fai/tabsVariable.inc
+++ b/plugins/admin/fai/tabsVariable.inc
@@ -39,6 +39,9 @@ class tabsVariable extends tabs
        $this->dn= $new_dn;
 
        tabs::save(TRUE);
+
+       /* Fix tagging if needed */
+       $baseobject->handle_object_tagging();
   }
 
 }

diff --git a/plugins/admin/groups/tabs_group.inc b/plugins/admin/groups/tabs_group.inc
index d970ec9ce0b5295909645287e950a8ede665978b..e454339422e9676c75696e1b83f6822e8f397a47 100644 (file)
--- a/plugins/admin/groups/tabs_group.inc
+++ b/plugins/admin/groups/tabs_group.inc
@@ -65,7 +65,12 @@ class grouptabs extends tabs
                        $this->dn= $new_dn;
                }
 
-               return tabs::save();
+               $ret= tabs::save();
+
+               /* Fix tagging if needed */
+               $baseobject->handle_object_tagging();
+
+               return $ret;
        }
 
        function saveCopyDialog()

diff --git a/plugins/admin/ogroups/tabs_ogroups.inc b/plugins/admin/ogroups/tabs_ogroups.inc
index 3e4979224223e031491792f994eac0145bb7e897..9867ffdd29bc08531486849a1bc8ad0661b89c24 100644 (file)
--- a/plugins/admin/ogroups/tabs_ogroups.inc
+++ b/plugins/admin/ogroups/tabs_ogroups.inc
@@ -224,6 +224,9 @@ class ogrouptabs extends tabs
     }
 
     tabs::save();
+
+    /* Fix tagging if needed */
+    $baseobject->handle_object_tagging();
   }
 
 }

diff --git a/plugins/admin/systems/tabs_component.inc b/plugins/admin/systems/tabs_component.inc
index deead42afbf482258c3e1b4a8d958ef2fb70c85b..597eadfbe09807b7de63bfd038df229a2d34c57d 100644 (file)
--- a/plugins/admin/systems/tabs_component.inc
+++ b/plugins/admin/systems/tabs_component.inc
@@ -26,6 +26,9 @@ class componenttabs extends tabs
     }
 
     tabs::save(TRUE);
+
+    /* Fix tagging if needed */
+    $baseobject->handle_object_tagging();
   }
 
 }

diff --git a/plugins/admin/systems/tabs_phone.inc b/plugins/admin/systems/tabs_phone.inc
index 60ccd3305945055d308ee8094cbb4eb686d452f4..742e2a0017eb822ce47b973f91a4d55efbbc44ed 100644 (file)
--- a/plugins/admin/systems/tabs_phone.inc
+++ b/plugins/admin/systems/tabs_phone.inc
@@ -26,6 +26,9 @@ class phonetabs extends tabs
     }
 
     tabs::save(TRUE);
+
+    /* Fix tagging if needed */
+    $baseobject->handle_object_tagging();
   }
 
 }

diff --git a/plugins/admin/systems/tabs_printers.inc b/plugins/admin/systems/tabs_printers.inc
index bb6a7ae86af3de757d4172e04815e0bb9e2056f6..2fe1c65db90bc5a40f52a5816ce33ec71af6b6c7 100644 (file)
--- a/plugins/admin/systems/tabs_printers.inc
+++ b/plugins/admin/systems/tabs_printers.inc
@@ -44,6 +44,9 @@ class printtabs extends tabs
     }
 
     tabs::save(FALSE);
+
+    /* Fix tagging if needed */
+    $baseobject->handle_object_tagging();
   }
 
 }

diff --git a/plugins/admin/systems/tabs_server.inc b/plugins/admin/systems/tabs_server.inc
index 12441a37e6ad669f8bceef9ef6d25a012dcbea43..9c87c84f2819b49daefb49c256a322e5b897e7d5 100644 (file)
--- a/plugins/admin/systems/tabs_server.inc
+++ b/plugins/admin/systems/tabs_server.inc
@@ -32,6 +32,9 @@ class servtabs extends tabs
     $config= $_SESSION['config'];
     $config->load_servers();
     $_SESSION['config']= $config;
+
+    /* Fix tagging if needed */
+    $baseobject->handle_object_tagging();
   }
 
 }

diff --git a/plugins/admin/systems/tabs_terminal.inc b/plugins/admin/systems/tabs_terminal.inc
index 5f5e47eea73c66a797388caf6ad1245446d9e24a..59f5dad25e84391ecf0234641a4034551f6d1667 100644 (file)
--- a/plugins/admin/systems/tabs_terminal.inc
+++ b/plugins/admin/systems/tabs_terminal.inc
@@ -53,6 +53,8 @@ class termtabs extends tabs
       $this->by_object['printgeneric']->remove_from_parent();
     }
 
+    /* Fix tagging if needed */
+    $baseobject->handle_object_tagging();
   }
 
 }

diff --git a/plugins/admin/systems/tabs_winstation.inc b/plugins/admin/systems/tabs_winstation.inc
index 062eac6ee989d3675d89ac9e694c59a27054c46e..fdcb6e4e6c9359dcc942788a4fa8b5e183027845 100644 (file)
--- a/plugins/admin/systems/tabs_winstation.inc
+++ b/plugins/admin/systems/tabs_winstation.inc
@@ -26,6 +26,9 @@ class wintabs extends tabs
     }
 
     tabs::save(TRUE);
+
+    /* Fix tagging if needed */
+    $baseobject->handle_object_tagging();
   }
 
 }

diff --git a/plugins/admin/systems/tabs_workstation.inc b/plugins/admin/systems/tabs_workstation.inc
index ce5a65298982249e23e4aebe5160a41395583635..4afdf8333840e5ed56a086f922ff74a80e8e2b58 100644 (file)
--- a/plugins/admin/systems/tabs_workstation.inc
+++ b/plugins/admin/systems/tabs_workstation.inc
@@ -49,6 +49,8 @@ class worktabs extends tabs
       $this->by_object['printgeneric']->remove_from_parent();
     }
 
+    /* Fix tagging if needed */
+    $baseobject->handle_object_tagging();
   }
 
 }

diff --git a/plugins/personal/generic/class_user.inc b/plugins/personal/generic/class_user.inc
index 0d7a9187310469b50310bd3680e41faf61ce9b6c..e7872c67f801757e6b5647242b75595ef37b5f53 100644 (file)
--- a/plugins/personal/generic/class_user.inc
+++ b/plugins/personal/generic/class_user.inc
@@ -921,6 +921,9 @@ class user extends plugin
       $this->handle_post_events("modify");
     }
 
+    /* Fix tagging if needed */
+    $this->handle_object_tagging();
+
     return (0);
   }