libcollectdclient: Fix off-by-one error when reading the username.

The allocated buffer includes a null byte, but the network packet doesn't.
That means we were reading one byte too many from the buffer, overwriting
the terminating null byte in the buffer.

diff --git a/src/libcollectdclient/network_parse.c b/src/libcollectdclient/network_parse.c
index 7139c9bc02fa0fa93efe35e22e365a248625195a..83a05d4f37d0da8b1e907de91bdd00a14dede122 100644 (file)
--- a/src/libcollectdclient/network_parse.c
+++ b/src/libcollectdclient/network_parse.c
@@ -441,7 +441,7 @@ static int parse_encrypt_aes256(void *data, size_t data_size,
     return ENOMEM;
   char username[((size_t)username_len) + 1];
   memset(username, 0, sizeof(username));
-  if (buffer_next(b, username, sizeof(username)))
+  if (buffer_next(b, username, (size_t)username_len))
     return EINVAL;
 
   char const *password = opts->password_lookup(username);