summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: d475536)
raw | patch | inline | side by side (parent: d475536)
author | Junio C Hamano <gitster@pobox.com> | |
Fri, 27 Jan 2012 19:58:56 +0000 (11:58 -0800) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Fri, 27 Jan 2012 19:58:56 +0000 (11:58 -0800) |
Curiously, pre_len given to read_length() does not trigger the same warning
even though the code structure is the same. Most likely this is because
read_offset() is used only once and inlining it will make gcc realize that
it has a chance to do more flow analysis. Alas, the analysis is flawed, so
it does not help X-<.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
even though the code structure is the same. Most likely this is because
read_offset() is used only once and inlining it will make gcc realize that
it has a chance to do more flow analysis. Alas, the analysis is flawed, so
it does not help X-<.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
vcs-svn/svndiff.c | patch | blob | history |
diff --git a/vcs-svn/svndiff.c b/vcs-svn/svndiff.c
index 9ee41bbc90807ddd82b63c9250f670fecf86a7f5..1647c1a780c5a6153455fdc73b6e422b474dab8e 100644 (file)
--- a/vcs-svn/svndiff.c
+++ b/vcs-svn/svndiff.c
if (read_magic(delta, &delta_len))
return -1;
while (delta_len) { /* For each window: */
- off_t pre_off;
+ off_t pre_off = pre_off; /* stupid GCC... */
size_t pre_len;
if (read_offset(delta, &pre_off, &delta_len) ||