Code

Let check_preimage() use memset() to initialize "struct checkout"
authorJens Lehmann <Jens.Lehmann@web.de>
Fri, 9 Apr 2010 20:08:35 +0000 (22:08 +0200)
committerJunio C Hamano <gitster@pobox.com>
Sat, 10 Apr 2010 05:42:57 +0000 (22:42 -0700)
Every code site except check_preimage() uses either memset() or declares
a static instance of "struct checkout" to achieve proper initialization.
Lets use memset() instead of explicit initialization of all members here
too to be on the safe side in case this structure is expanded someday.

Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin-apply.c

index 7ca90472c10eed8535e76b1e0ec25c92af7cff05..771c972c5506db4848e2c214fb617525bafdf335 100644 (file)
@@ -2824,11 +2824,8 @@ static int check_preimage(struct patch *patch, struct cache_entry **ce, struct s
                if (stat_ret < 0) {
                        struct checkout costate;
                        /* checkout */
+                       memset(&costate, 0, sizeof(costate));
                        costate.base_dir = "";
-                       costate.base_dir_len = 0;
-                       costate.force = 0;
-                       costate.quiet = 0;
-                       costate.not_new = 0;
                        costate.refresh_cache = 1;
                        if (checkout_entry(*ce, &costate, NULL) ||
                            lstat(old_name, st))