fetch-pack: do not use lockfile structure on stack.

They are used in atexit() for clean-up, and you will be
accessing unallocated memory at that point.

See 31f584c2 for the fix for a similar problem.

Signed-off-by: Junio C Hamano <junkio@cox.net>

diff --git a/fetch-pack.c b/fetch-pack.c
index c527bf9e9621519f72e1039313666a03ee12c586..1530a947947b68d879e01bb9161654e135716a3d 100644 (file)
--- a/fetch-pack.c
+++ b/fetch-pack.c
@@ -625,6 +625,8 @@ static int remove_duplicates(int nr_heads, char **heads)
        return dst;
 }
 
+static struct lock_file lock;
+
 int main(int argc, char **argv)
 {
        int i, ret, nr_heads;
@@ -632,7 +634,6 @@ int main(int argc, char **argv)
        int fd[2];
        pid_t pid;
        struct stat st;
-       struct lock_file lock;
 
        setup_git_directory();