Drop use of $(...) for popen() and system() calls

Some shells don't support it, like the jsh that is used as /bin/sh on
some Solaris boxes, which results in the following error:

	sh: syntax error at line 1: `(' unexpected

Fix the only user (reading remote information via git-ls-remote) to use
a much simpler shell syntax.

Reported by SungHyun Nam.

diff --git a/NEWS b/NEWS
index 72efd048af1f301f06b8f7c50e66587b0a85999b..626c8243f85258e7fd2904c9249d364f0a74dfb9 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -15,6 +15,8 @@ Bug fixes:
  - Fix regression when staging all diff chunks in a section.
  - Bind the maximize view action to 'O'; it conflicted with the
    keybinding to launch the merge tool in the status view.
+ - Fix problem with $(cmd) usage in shell code. Some shells (jsh)
+   installed as /bin/sh does not support it.
 
 tig-0.11
 --------

diff --git a/tig.c b/tig.c
index 67d0693f5f99dbee4913d0ca79b51b15712b6570..c50ea841766c0ec64665e4d30966b86dee3951f0 100644 (file)
--- a/tig.c
+++ b/tig.c
@@ -109,7 +109,7 @@ static size_t utf8_length(const char *string, int *width, size_t max_width, int
 #endif
 
 #define TIG_LS_REMOTE \
-       "git ls-remote $(git rev-parse --git-dir) 2>/dev/null"
+       "git ls-remote . 2>/dev/null"
 
 #define TIG_DIFF_CMD \
        "git show --pretty=fuller --no-color --root --patch-with-stat --find-copies-harder -C %s 2>/dev/null"