Code

[PATCH] quote.c: Make loop control more readable.
authorPavel Roskin <proski@gnu.org>
Wed, 21 Dec 2005 20:35:48 +0000 (15:35 -0500)
committerJunio C Hamano <junkio@cox.net>
Wed, 21 Dec 2005 21:28:24 +0000 (13:28 -0800)
quote_c_style_counted() in quote.c uses a hard-to-read  construct.
Convert this to a more traditional form of the for loop.

Signed-off-by: Pavel Roskin <proski@gnu.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
quote.c

diff --git a/quote.c b/quote.c
index 76eb14426581f03d0b15ee4eb720456a0729d1bc..7218a7080d9a4282530b58c013606c86e4a5fdf5 100644 (file)
--- a/quote.c
+++ b/quote.c
@@ -126,8 +126,10 @@ static int quote_c_style_counted(const char *name, int namelen,
 
        if (!no_dq)
                EMIT('"');
-       for (sp = name; (ch = *sp++) && (sp - name) <= namelen; ) {
-
+       for (sp = name; sp < name + namelen; sp++) {
+               ch = *sp;
+               if (!ch)
+                       break;
                if ((ch < ' ') || (ch == '"') || (ch == '\\') ||
                    (ch == 0177)) {
                        needquote = 1;