Code

gitweb: Move 'lineno' id from link to row element in git_blame
authorJakub Narebski <jnareb@gmail.com>
Tue, 9 Dec 2008 22:46:16 +0000 (23:46 +0100)
committerJunio C Hamano <gitster@pobox.com>
Wed, 10 Dec 2008 06:09:11 +0000 (22:09 -0800)
Move l<line number> ID from <a> link element inside table row (inside
cell element for column with line numbers), to encompassing <tr> table
row element.  It was done to make it easier to manipulate result HTML
with DOM, and to be able write 'blame_incremental' view with the same,
or nearly the same result.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Acked-by: Luben Tuikov <ltuikov@yahoo.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
gitweb/gitweb.perl

index 951739210a3278802e5ab7eb00bd5d0679deccce..e01e1afe95bc49b0ab264bcdd8ee91af5deee23a 100755 (executable)
@@ -4645,7 +4645,7 @@ HTML
                if ($group_size) {
                        $current_color = ++$current_color % $num_colors;
                }
-               print "<tr class=\"$rev_color[$current_color]\">\n";
+               print "<tr id=\"l$lineno\" class=\"$rev_color[$current_color]\">\n";
                if ($group_size) {
                        print "<td class=\"sha1\"";
                        print " title=\"". esc_html($author) . ", $date\"";
@@ -4667,7 +4667,6 @@ HTML
                                  hash_base => $parent_commit);
                print "<td class=\"linenr\">";
                print $cgi->a({ -href => "$blamed#l$orig_lineno",
-                               -id => "l$lineno",
                                -class => "linenr" },
                              esc_html($lineno));
                print "</td>";