summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: f3b1fbf)
raw | patch | inline | side by side (parent: f3b1fbf)
author | Brandon Casey <drafnel@gmail.com> | |
Sat, 20 Mar 2010 00:10:20 +0000 (19:10 -0500) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Sat, 20 Mar 2010 15:22:32 +0000 (08:22 -0700) |
This test is supposed to check that git-remote correctly refuses to delete
all URLS for the specified remote which match the '.*' regular expression.
Since the '*' was not protected, it was interpreted by the shell as a file
glob and expanded before being passed to git-remote. The call to
git-remote still exited non-zero in this case, and the overall test still
passed, but it exited non-zero because git-remote was passed the incorrect
number of arguments, not for the reason it was supposed to fail.
Correct the test by escaping the '*'.
Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
all URLS for the specified remote which match the '.*' regular expression.
Since the '*' was not protected, it was interpreted by the shell as a file
glob and expanded before being passed to git-remote. The call to
git-remote still exited non-zero in this case, and the overall test still
passed, but it exited non-zero because git-remote was passed the incorrect
number of arguments, not for the reason it was supposed to fail.
Correct the test by escaping the '*'.
Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t5505-remote.sh | patch | blob | history |
diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh
index e7afe9e16e368e132e9b91d4397ccd57954678d8..acfea06b81e95e0b9cdb621200dc6c6620b70107 100755 (executable)
--- a/t/t5505-remote.sh
+++ b/t/t5505-remote.sh
'
test_expect_success 'remote set-url --delete .*' '
- test_must_fail git remote set-url --delete someremote .* &&
+ test_must_fail git remote set-url --delete someremote .\* &&
echo "YYY" >expect &&
echo baz >>expect &&
echo bbb >>expect &&