summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 777f80d)
raw | patch | inline | side by side (parent: 777f80d)
author | Junio C Hamano <gitster@pobox.com> | |
Fri, 3 Dec 2010 20:28:00 +0000 (12:28 -0800) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Fri, 3 Dec 2010 20:28:00 +0000 (12:28 -0800) |
We really shouldn't be using these funny /dev/* files that did not exist
in V7 UNIX in our tests when we do not have to.
Output from
$ git grep -n -e /dev/ --and --not -e /dev/null t/
tells us that, aside from use of /dev/urandom in apache.conf used in http
tests, "dd if=/dev/stdin" added recently to t/t9300-fast-import.sh are the
only offenders, and "dd" reads from the standard input by default, so
removing them should be straightforward.
Reported-by: Thomas Rast <trast@student.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
in V7 UNIX in our tests when we do not have to.
Output from
$ git grep -n -e /dev/ --and --not -e /dev/null t/
tells us that, aside from use of /dev/urandom in apache.conf used in http
tests, "dd if=/dev/stdin" added recently to t/t9300-fast-import.sh are the
only offenders, and "dd" reads from the standard input by default, so
removing them should be straightforward.
Reported-by: Thomas Rast <trast@student.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t9300-fast-import.sh | patch | blob | history |
diff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh
index d615d04a32cd96cf2de5ccec3cd1a66dddca8620..055ddc6ddc711de51eb53660572d4527c68450fb 100755 (executable)
--- a/t/t9300-fast-import.sh
+++ b/t/t9300-fast-import.sh
read blob_id type size <&3 &&
echo "$blob_id $type $size" >response &&
- dd if=/dev/stdin of=blob bs=$size count=1 <&3 &&
+ dd of=blob bs=$size count=1 <&3 &&
read newline <&3 &&
cat <<EOF &&
EOF
read blob_id type size <&3 &&
- dd if=/dev/stdin of=actual bs=$size count=1 <&3 &&
+ dd of=actual bs=$size count=1 <&3 &&
read newline <&3 &&
echo
echo "cat-blob $to_get" &&
read blob_id type size <&3 &&
- dd if=/dev/stdin of=actual bs=$size count=1 <&3 &&
+ dd of=actual bs=$size count=1 <&3 &&
read newline <&3 &&
echo deleteall