A simple fix of the bad wrapping bugs

This was surprisingly simple to fix by just turning off scrolling in
draw_view_line. From the BUGS file:

 - If the screen width is very small the main view can draw outside the
   current view causing bad wrapping. Same goes for title and status
   windows.

 - The cursor can wrap-around on the last line and cause the window to
   scroll.

diff --git a/BUGS b/BUGS
index 79aace6fd064e9af8808fae7f332aa27e36ecd63..0783a2eb80ad2ca70472c275fc3a02c948709ed9 100644 (file)
--- a/BUGS
+++ b/BUGS
@@ -3,10 +3,3 @@ BUGS
 Known bugs and problems:
 
  - In it's current state tig is pretty much UTF-8 only.
-
- - If the screen width is very small the main view can draw
-   outside the current view causing bad wrapping. Same goes
-   for title and status windows.
-
- - The cursor can wrap-around on the last line and cause the
-   window to scroll.

diff --git a/tig.c b/tig.c
index 1a5ed4af81f7e1117d1767802d2da38fa4032fc9..b0ce18ff29f103cc89d157630ae8026309de88c6 100644 (file)
--- a/tig.c
+++ b/tig.c
@@ -1265,6 +1265,7 @@ draw_view_line(struct view *view, unsigned int lineno)
 {
        struct line *line;
        bool selected = (view->offset + lineno == view->lineno);
+       bool draw_ok;
 
        assert(view_is_displayed(view));
 
@@ -1282,7 +1283,11 @@ draw_view_line(struct view *view, unsigned int lineno)
                wclrtoeol(view->win);
        }
 
-       return view->ops->draw(view, line, lineno, selected);
+       scrollok(view->win, FALSE);
+       draw_ok = view->ops->draw(view, line, lineno, selected);
+       scrollok(view->win, TRUE);
+
+       return draw_ok;
 }
 
 static void