summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: eb44b1e)
raw | patch | inline | side by side (parent: eb44b1e)
author | Florian Forster <octo@collectd.org> | |
Sun, 23 Sep 2012 10:00:43 +0000 (12:00 +0200) | ||
committer | Florian Forster <octo@collectd.org> | |
Sun, 23 Sep 2012 10:00:43 +0000 (12:00 +0200) |
The last element in "interfaces" is not guaranteed to be zeroed, resulting in a
segfault when cf_util_get_string() tries to free the "pointer".
Thanks to Mark T. Voelker for reporting and analyzing this bug!
This should fix Github issue #133.
segfault when cf_util_get_string() tries to free the "pointer".
Thanks to Mark T. Voelker for reporting and analyzing this bug!
This should fix Github issue #133.
src/ethstat.c | patch | blob | history |
diff --git a/src/ethstat.c b/src/ethstat.c
index 746fc613d0d332a883d947c0029c5640d6e006b4..08381a821087e275fb03922a32bc54c35ca7c3cd 100644 (file)
--- a/src/ethstat.c
+++ b/src/ethstat.c
if (tmp == NULL)
return (-1);
interfaces = tmp;
+ interfaces[interfaces_num] = NULL;
status = cf_util_get_string (ci, interfaces + interfaces_num);
if (status != 0)