Code

Fix uninteresting tags in new revision parsing
authorLinus Torvalds <torvalds@osdl.org>
Wed, 19 Apr 2006 03:31:41 +0000 (20:31 -0700)
committerJunio C Hamano <junkio@cox.net>
Wed, 19 Apr 2006 04:08:06 +0000 (21:08 -0700)
When I unified the revision argument parsing, I introduced a simple bug
wrt tags that had been marked uninteresting. When it was preparing for the
revision walk, it would mark all the parent commits of an uninteresting
tag correctly uninteresting, but it would forget about the commit itself.

This means that when I just did my 2.6.17-rc2 release, and my scripts
generated the log for "v2.6.17-rc1..v2.6.17-rc2", everything was fine,
except the commit pointed to by 2.6.17-rc1 (which shouldn't have been
there) was included. Even though it should obviously have been marked as
being uninteresting.

Not a huge deal, and the fix is trivial.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
revision.c

index dbd54da5baec5b5a2320a40a66da24541705e971..113dd5a89fc03ff17b04443f2ac7148b4c36af33 100644 (file)
@@ -152,6 +152,7 @@ static struct commit *handle_commit(struct rev_info *revs, struct object *object
                if (parse_commit(commit) < 0)
                        die("unable to parse commit %s", name);
                if (flags & UNINTERESTING) {
+                       commit->object.flags |= UNINTERESTING;
                        mark_parents_uninteresting(commit);
                        revs->limited = 1;
                }