Code

bindings/perl/Oping.xs: Fix an off-by-one error when allocating a Perl string.
authorFredrik Soderblom <fredrik@xpd.se>
Thu, 1 Oct 2009 12:24:46 +0000 (14:24 +0200)
committerFlorian Forster <octo@leeloo.lan.home.verplant.org>
Thu, 1 Oct 2009 12:24:46 +0000 (14:24 +0200)
In the previous code the null byte was included in the Perl string,
making the string handling awkward.

bindings/perl/Oping.xs

index 6106e13760cae899222033299c08e0f88ab35b8d..5731d3d8088f28d4df8eb826dba4ab232b1b1b98 100644 (file)
@@ -183,8 +183,9 @@ _ping_iterator_get_hostname (iter)
                        free (buffer);
                        break;
                }
+               buffer[buffer_size - 1] = 0;
 
-               XPUSHs (sv_2mortal (newSVpvn(buffer,buffer_size)));
+               XPUSHs (sv_2mortal (newSVpvn(buffer, strlen (buffer))));
                free(buffer);
        } while (0);