Code

git-svn: support fetch with autocrlf on
authorErik Faye-Lund <kusmabite@googlemail.com>
Wed, 3 Mar 2010 20:10:22 +0000 (21:10 +0100)
committerEric Wong <normalperson@yhbt.net>
Fri, 5 Mar 2010 10:57:57 +0000 (02:57 -0800)
Before commit d3c9634e, performing a "git svn rebase" that fetched a
change containing CRLFs corrupted the git-svn meta-data. This was
worked around in d3c9634e by setting core.autocrlf to "false" in the
per-repo config when initing the clone. However, if the config
variable was later changed, the corruption would still occur.

This patch tries to fix it while allowing core.autocrlf to be
enabled, by disabling filters when when hashing.

git-svn is currently the only call-site for hash_and_insert_object
(apart from the test-suite), so changing it should be safe.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Acked-by: Eric Wong <normalperson@yhbt.net>
perl/Git.pm

index 970fe434ed02e1850b984ddcbdbff6c13a21083c..1926dc9a4b929c025456227526a93424d4972948 100644 (file)
@@ -842,7 +842,7 @@ sub _open_hash_and_insert_object_if_needed {
 
        ($self->{hash_object_pid}, $self->{hash_object_in},
         $self->{hash_object_out}, $self->{hash_object_ctx}) =
-               command_bidi_pipe(qw(hash-object -w --stdin-paths));
+               command_bidi_pipe(qw(hash-object -w --stdin-paths --no-filters));
 }
 
 sub _close_hash_and_insert_object {