Code

Fix bug introduced by the latest changes to git-pack-redundant
authorLukas Sandström <lukass@etek.chalmers.se>
Fri, 18 Nov 2005 16:30:29 +0000 (17:30 +0100)
committerJunio C Hamano <junkio@cox.net>
Fri, 18 Nov 2005 19:20:34 +0000 (11:20 -0800)
I forgot to initialize part of the pll struct when copying it.
Found by valgrind.

Signed-off-by: Lukas Sandström <lukass@etek.chalmers.se>
Signed-off-by: Junio C Hamano <junkio@cox.net>
pack-redundant.c

index 51d7341b0b9d4900606998702b9520b604a5aaf9..36556092c9210c9623eefe3b02841e61ffb26651 100644 (file)
@@ -439,7 +439,7 @@ void minimize(struct pack_list **min)
                        break; /* ignore all larger permutations */
                if (is_superset(perm->pl, missing)) {
                        new_perm = xmalloc(sizeof(struct pll));
-                       new_perm->pl = perm->pl;
+                       memcpy(new_perm, perm, sizeof(struct pll));
                        new_perm->next = perm_ok;
                        perm_ok = new_perm;
                }