Merge branch 'maint'

* maint:
  git-svn: Fix git svn log --show-commit

diff --git a/git-svn.perl b/git-svn.perl
index 0fd2fd2188b93fe15bda901f512bd55ad3a5034a..7849cfc141d384bc28479c2f37fd128c77fe0fbe 100755 (executable)
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -5765,7 +5765,7 @@ sub cmd_show_log {
        my (@k, $c, $d, $stat);
        my $esc_color = qr/(?:\033\[(?:(?:\d+;)*\d*)?m)*/;
        while (<$log>) {
-               if (/^${esc_color}commit (- )?($::sha1_short)/o) {
+               if (/^${esc_color}commit (?:- )?($::sha1_short)/o) {
                        my $cmt = $1;
                        if ($c && cmt_showable($c) && $c->{r} != $r_last) {
                                $r_last = $c->{r};

diff --git a/t/t9116-git-svn-log.sh b/t/t9116-git-svn-log.sh
index 5d477e4bdadd2168d0331e2ab809c5c86c8fa532..cf4c05261b42ddd0711f78951adfc4a49ffdcc1e 100755 (executable)
--- a/t/t9116-git-svn-log.sh
+++ b/t/t9116-git-svn-log.sh
@@ -60,6 +60,21 @@ test_expect_success 'test ascending revision range' "
        git svn log -r 1:4 | grep '^r[0-9]' | cut -d'|' -f1 | test_cmp expected-range-r1-r2-r4 -
        "
 
+test_expect_success 'test ascending revision range with --show-commit' "
+       git reset --hard trunk &&
+       git svn log --show-commit -r 1:4 | grep '^r[0-9]' | cut -d'|' -f1 | test_cmp expected-range-r1-r2-r4 -
+       "
+
+test_expect_success 'test ascending revision range with --show-commit (sha1)' "
+       git svn find-rev r1 >expected-range-r1-r2-r4-sha1 &&
+       git svn find-rev r2 >>expected-range-r1-r2-r4-sha1 &&
+       git svn find-rev r4 >>expected-range-r1-r2-r4-sha1 &&
+       git reset --hard trunk &&
+       git svn log --show-commit -r 1:4 | grep '^r[0-9]' | cut -d'|' -f2 >out &&
+       git rev-parse \$(cat out) >actual &&
+       test_cmp expected-range-r1-r2-r4-sha1 actual
+       "
+
 printf 'r4 \nr2 \nr1 \n' > expected-range-r4-r2-r1
 
 test_expect_success 'test descending revision range' "