Code

df plugin: Guard strcmp() against being passed NULL pointers.
authorFlorian Forster <octo@collectd.org>
Fri, 2 Sep 2016 06:38:57 +0000 (08:38 +0200)
committerFlorian Forster <octo@collectd.org>
Fri, 2 Sep 2016 06:38:57 +0000 (08:38 +0200)
Issue: #1835

src/df.c

index 4a86799c2e5d7ec7a3bbb6b3003bca8879eede0b..af54c92f9f7da4ce3c919deb11d93c12478e8d85 100644 (file)
--- a/src/df.c
+++ b/src/df.c
@@ -229,7 +229,10 @@ static int df_read (void)
                        }
 
                        /* Duplicate found: leave non-NULL dup_ptr. */
-                       if (by_device && (strcmp (mnt_ptr->spec_device, dup_ptr->spec_device) == 0))
+                       if (by_device
+                            && (mnt_ptr->spec_device != NULL)
+                            && (dup_ptr->spec_device != NULL)
+                            && (strcmp (mnt_ptr->spec_device, dup_ptr->spec_device) == 0))
                                break;
                        else if (!by_device && (strcmp (mnt_ptr->dir, dup_ptr->dir) == 0))
                                break;