Don't access freed memory

The fields array contains pointers into the value_copy string.

diff --git a/src/virt.c b/src/virt.c
index 69a46071f339b5fab303e3af1c56c1affe08c819..663555b9bd33a2375d717482987041824a3f5c76 100644 (file)
--- a/src/virt.c
+++ b/src/virt.c
@@ -417,8 +417,8 @@ lv_config (const char *key, const char *value)
             else if (strcasecmp (fields[i], "uuid") == 0)
                 hostname_format[i] = hf_uuid;
             else {
-                sfree (value_copy);
                 ERROR (PLUGIN_NAME " plugin: unknown HostnameFormat field: %s", fields[i]);
+                sfree (value_copy);
                 return -1;
             }
         }
@@ -454,8 +454,8 @@ lv_config (const char *key, const char *value)
             else if (strcasecmp (fields[i], "uuid") == 0)
                 plugin_instance_format[i] = plginst_uuid;
             else {
-                sfree (value_copy);
                 ERROR (PLUGIN_NAME " plugin: unknown PluginInstanceFormat field: %s", fields[i]);
+                sfree (value_copy);
                 return -1;
             }
         }