Code

network plugin: Check range of pkg_numval.
authorFlorian Forster <octo@collectd.org>
Fri, 18 Dec 2015 08:24:19 +0000 (09:24 +0100)
committerFlorian Forster <octo@collectd.org>
Fri, 18 Dec 2015 08:24:19 +0000 (09:24 +0100)
This is essentially the same as the check using exp_size a couple lines
earlier, but that appears to be too indirect for Coverity to understand.
This hopefully fixes the resulting "tainted_data_return" errors.

CID: 48420

src/network.c

index 916900065aff9241a99454ab86cd2bf675655d8f..f44fe621c1717a16ab0d5a2dbb236e89397a3cf2 100644 (file)
@@ -817,6 +817,7 @@ static int parse_part_values (void **ret_buffer, size_t *ret_buffer_len,
                                exp_size, buffer_len);
                return (-1);
        }
+       assert (pkg_numval <= ((buffer_len - 6) / 9));
 
        if (pkg_length != exp_size)
        {