Code

git-send-email: default value for "From:" field.
authorQuy Tonthat <qtonthat@gmail.com>
Wed, 27 Dec 2006 14:16:21 +0000 (01:16 +1100)
committerJunio C Hamano <junkio@cox.net>
Wed, 27 Dec 2006 22:18:57 +0000 (14:18 -0800)
If user hits enter at the prompt for
"Who should the emails appear to be from?",
the value for "From:" field was emptied instead of GIT_COMMITER_IDENT.

Signed-off-by: Quy Tonthat <qtonthat@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
git-send-email.perl

index 4c87c20c158fe3edfd0b770f1855e67e20038e3b..ba39d393843733b46f309deb105c90cabcee2cb1 100755 (executable)
@@ -178,11 +178,10 @@ my $prompting = 0;
 if (!defined $from) {
        $from = $author || $committer;
        do {
-               $_ = $term->readline("Who should the emails appear to be from? ",
-                       $from);
+               $_ = $term->readline("Who should the emails appear to be from? [$from] ");
        } while (!defined $_);
 
-       $from = $_;
+       $from = $_ if ($_);
        print "Emails will be sent from: ", $from, "\n";
        $prompting++;
 }