write_http plugin: Sanity check arguments to wh_write_command().

Issue: #1835

diff --git a/src/write_http.c b/src/write_http.c
index 95132cf92f7bcd8d541bd53aa38a34b72de28c9a..41615d3f0ccbd0be9c1cefba46708a4ace10e680 100644 (file)
--- a/src/write_http.c
+++ b/src/write_http.c
@@ -362,7 +362,11 @@ static int wh_write_command (const data_set_t *ds, const value_list_t *vl, /* {{
 
         int status;
 
-        if (0 != strcmp (ds->type, vl->type)) {
+        /* sanity checks, primarily to make static analyzers happy. */
+        if ((cb == NULL) || (cb->send_buffer == NULL))
+                return -1;
+
+        if (strcmp (ds->type, vl->type) == 0) {
                 ERROR ("write_http plugin: DS type does not match "
                                 "value list type");
                 return -1;