Code

fmt-merge-msg: minor refactor of fmt_merge_msg()
authorTay Ray Chuan <rctay89@gmail.com>
Mon, 10 May 2010 17:17:49 +0000 (01:17 +0800)
committerJunio C Hamano <gitster@pobox.com>
Mon, 10 May 2010 18:57:33 +0000 (11:57 -0700)
Shift implementation into a private function, do_fmt_merge_msg(). This
allows for further changes to the implementation, without affecting the
interface.

Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/fmt-merge-msg.c

index 379a03131fbd84fb2b45a6b05e62daf82b7e4947..a2bccd6ea4ac14441a6657bc1882cd180ec52b80 100644 (file)
@@ -202,7 +202,8 @@ static void shortlog(const char *name, unsigned char *sha1,
        string_list_clear(&subjects, 0);
 }
 
-int fmt_merge_msg(int merge_summary, struct strbuf *in, struct strbuf *out) {
+static int do_fmt_merge_msg(int merge_summary, struct strbuf *in,
+       struct strbuf *out) {
        int limit = 20, i = 0, pos = 0;
        char *sep = "";
        unsigned char head_sha1[20];
@@ -296,6 +297,10 @@ int fmt_merge_msg(int merge_summary, struct strbuf *in, struct strbuf *out) {
        return 0;
 }
 
+int fmt_merge_msg(int merge_summary, struct strbuf *in, struct strbuf *out) {
+       return do_fmt_merge_msg(merge_summary, in, out);
+}
+
 int cmd_fmt_merge_msg(int argc, const char **argv, const char *prefix)
 {
        const char *inpath = NULL;