Code

cvsserver: always initialize state in argsplit()
authorFrank Lichtenheld <frank@lichtenheld.de>
Sun, 17 Jun 2007 08:31:02 +0000 (10:31 +0200)
committerJunio C Hamano <gitster@pobox.com>
Sat, 7 Jul 2007 06:13:34 +0000 (23:13 -0700)
Other code assumes that this is initialized, so do it
even if there were no arguments given.

Signed-off-by: Dirk Koopman <djk@tobit.co.uk>
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
git-cvsserver.perl

index 5cbf27eebc0f090c0d7e45e82064344b30d326fc..10aba507d731b977d354fcbf67ecf9112ec1579c 100755 (executable)
@@ -1813,14 +1813,14 @@ sub req_annotate
 # the second is $state->{files} which is everything after it.
 sub argsplit
 {
-    return unless( defined($state->{arguments}) and ref $state->{arguments} eq "ARRAY" );
-
-    my $type = shift;
-
     $state->{args} = [];
     $state->{files} = [];
     $state->{opt} = {};
 
+    return unless( defined($state->{arguments}) and ref $state->{arguments} eq "ARRAY" );
+
+    my $type = shift;
+
     if ( defined($type) )
     {
         my $opt = {};