summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: a1818d6)
raw | patch | inline | side by side (parent: a1818d6)
author | Florian Forster <octo@leeloo.lan.home.verplant.org> | |
Tue, 29 Sep 2009 14:37:48 +0000 (16:37 +0200) | ||
committer | Florian Forster <octo@leeloo.lan.home.verplant.org> | |
Tue, 29 Sep 2009 14:37:48 +0000 (16:37 +0200) |
They've been renamed to “GetCapacity” and “GetSnapshot” so the
names used within the “VolumeUsage” block are the same as the names
used elsewhere in the plugin.
names used within the “VolumeUsage” block are the same as the names
used elsewhere in the plugin.
src/collectd.conf.pod | patch | blob | history | |
src/netapp.c | patch | blob | history |
diff --git a/src/collectd.conf.pod b/src/collectd.conf.pod
index f3f2f48f7bb266cb056f36e4cbe6d8bc48c737a0..ff44ba1591bc82e253c09012749f3ce3fa60b75b 100644 (file)
--- a/src/collectd.conf.pod
+++ b/src/collectd.conf.pod
</VolumePerf>
<VolumeUsage>
- Capacity "vol0"
- Capacity "vol1"
+ GetCapacity "vol0"
+ GetCapacity "vol1"
IgnoreSelectedCapacity false
- Snapshot "vol1"
- Snapshot "vol3"
+ GetSnapshot "vol1"
+ GetSnapshot "vol3"
IgnoreSelectedSnapshot false
</VolumeUsage>
=over 4
-=item B<Capacity> I<VolumeName>
+=item B<GetCapacity> I<VolumeName>
The current capacity of the volume will be collected. This will result in two
to four value lists, depending on the configuration of the volume. All data
=item B<IgnoreSelectedCapacity> B<true>|B<false>
-Specify whether to collect only the volumes selected by the B<Capacity> option
-or to ignore those volumes. B<IgnoreSelectedCapacity> defaults to B<false>.
-However, if no B<Capacity> option is specified at all, all capacities will be
-selected anyway.
+Specify whether to collect only the volumes selected by the B<GetCapacity>
+option or to ignore those volumes. B<IgnoreSelectedCapacity> defaults to
+B<false>. However, if no B<GetCapacity> option is specified at all, all
+capacities will be selected anyway.
-=item B<Snapshot> I<VolumeName>
+=item B<GetSnapshot> I<VolumeName>
B<Defunct!> Select volumes from which to collect snapshot information.
=item B<IgnoreSelectedSnapshot>
-Specify whether to collect only the volumes selected by the B<Snapshot> option
-or to ignore those volumes. B<IgnoreSelectedSnapshot> defaults to B<false>.
-However, if no B<Snapshot> option is specified at all, all capacities will be
-selected anyway.
+Specify whether to collect only the volumes selected by the B<GetSnapshot>
+option or to ignore those volumes. B<IgnoreSelectedSnapshot> defaults to
+B<false>. However, if no B<GetSnapshot> option is specified at all, all
+capacities will be selected anyway.
=back
diff --git a/src/netapp.c b/src/netapp.c
index d8077e2b1bc486e30498f8ad78a9b78e50d56886..bea86f654a537989bbfa4cfc5ca0ad96e3757694 100644 (file)
--- a/src/netapp.c
+++ b/src/netapp.c
return (0);
} /* }}} int cna_config_volume_performance */
-/* Handling of the "Capacity" and "Snapshot" options within a <VolumeUsage />
- * block. */
+/* Handling of the "GetCapacity" and "GetSnapshot" options within a
+ * <VolumeUsage /> block. */
static void cna_config_volume_usage_option (cfg_volume_usage_t *cvu, /* {{{ */
const oconfig_item_t *ci)
{
@@ -1940,9 +1940,9 @@ static void cna_config_volume_usage_option (cfg_volume_usage_t *cvu, /* {{{ */
name = ci->values[0].value.string;
- if (strcasecmp ("Capacity", ci->key) == 0)
+ if (strcasecmp ("GetCapacity", ci->key) == 0)
il = cvu->il_capacity;
- else if (strcasecmp ("Snapshot", ci->key) == 0)
+ else if (strcasecmp ("GetSnapshot", ci->key) == 0)
il = cvu->il_snapshot;
else
return;
@@ -2076,17 +2076,17 @@ static int cna_config_wafl(host_config_t *host, oconfig_item_t *ci) /* {{{ */
/*
* <VolumeUsage>
- * Capacity "vol0"
- * Capacity "vol1"
- * Capacity "vol2"
- * Capacity "vol3"
- * Capacity "vol4"
+ * GetCapacity "vol0"
+ * GetCapacity "vol1"
+ * GetCapacity "vol2"
+ * GetCapacity "vol3"
+ * GetCapacity "vol4"
* IgnoreSelectedCapacity false
*
- * Snapshot "vol0"
- * Snapshot "vol3"
- * Snapshot "vol4"
- * Snapshot "vol7"
+ * GetSnapshot "vol0"
+ * GetSnapshot "vol3"
+ * GetSnapshot "vol4"
+ * GetSnapshot "vol7"
* IgnoreSelectedSnapshot false
* </VolumeUsage>
*/
/* if (!item || !item->key || !*item->key) continue; */
if (strcasecmp(item->key, "Interval") == 0)
cna_config_get_interval (item, &cfg_volume_usage->interval);
- else if (!strcasecmp(item->key, "Capacity"))
+ else if (!strcasecmp(item->key, "GetCapacity"))
cna_config_volume_usage_option (cfg_volume_usage, item);
- else if (!strcasecmp(item->key, "Snapshot"))
+ else if (!strcasecmp(item->key, "GetSnapshot"))
cna_config_volume_usage_option (cfg_volume_usage, item);
else if (!strcasecmp(item->key, "IgnoreSelectedCapacity"))
cna_config_volume_usage_default (cfg_volume_usage, item);