r15481@tres: ted | 2007-05-22 09:56:22 -0700

 Switching to sigc::signal so it actually works.

diff --git a/src/extension/effect.cpp b/src/extension/effect.cpp
index d18599d62bea3ab10e358a3935bc70419d933fd2..80dc776e3aa62e789eea902b95cd872fb2aa6f71 100644 (file)
--- a/src/extension/effect.cpp
+++ b/src/extension/effect.cpp
@@ -2,7 +2,7 @@
  * Authors:
  *   Ted Gould <ted@gould.cx>
  *
- * Copyright (C) 2002-2006 Authors
+ * Copyright (C) 2002-2007 Authors
  *
  * Released under GNU GPL, read the file 'COPYING' for more information
  */
@@ -364,9 +364,7 @@ Effect::prefs (Inkscape::UI::View::View * doc)
         set_state(Extension::STATE_LOADED);
     if (!loaded()) return false;
 
-    Glib::SignalProxyInfo changeSignalInfo = {signal_name: "Effect Preference Changed",
-                                              callback: NULL, notify_callback: NULL};
-    Glib::SignalProxy0<void> changeSignal(NULL, &changeSignalInfo);
+    sigc::signal<void> changeSignal;
 
     Gtk::Widget * controls;
     controls = imp->prefs_effect(this, doc, &changeSignal);
@@ -376,7 +374,7 @@ Effect::prefs (Inkscape::UI::View::View * doc)
     }
 
     ExecutionEnv executionEnv(this, doc, controls);
-    //changeSignal.connect(sigc::mem_fun(executionEnv, &ExecutionEnv::preferencesChange));
+    changeSignal.connect(sigc::mem_fun(executionEnv, &ExecutionEnv::preferencesChange));
     executionEnv.run();
 
     return true;

diff --git a/src/extension/extension.cpp b/src/extension/extension.cpp
index ffb533eda4fe2044eb2a3ca6500509bc0834e541..20aff9c03519eaa311bee643460fe678d47dcb07 100644 (file)
--- a/src/extension/extension.cpp
+++ b/src/extension/extension.cpp
@@ -623,7 +623,7 @@ public:
     If there are no parameters, this function just returns NULL.
 */
 Gtk::Widget *
-Extension::autogui (SPDocument * doc, Inkscape::XML::Node * node, Glib::SignalProxy0<void> * changeSignal)
+Extension::autogui (SPDocument * doc, Inkscape::XML::Node * node, sigc::signal<void> * changeSignal)
 {
     if (g_slist_length(parameters) == 0) return NULL;
 

diff --git a/src/extension/extension.h b/src/extension/extension.h
index d1613e71103dc098236e9049fbb97cd8905090a4..a1993f941b8473d7a82f4bb3da061985e68f8343 100644 (file)
--- a/src/extension/extension.h
+++ b/src/extension/extension.h
@@ -182,7 +182,7 @@ public:
     static void      error_file_close (void);
 
 public:
-    Gtk::Widget *    autogui (SPDocument * doc, Inkscape::XML::Node * node, Glib::SignalProxy0<void> * changeSignal = NULL);
+    Gtk::Widget *    autogui (SPDocument * doc, Inkscape::XML::Node * node, sigc::signal<void> * changeSignal = NULL);
     void paramListString (std::list <std::string> & retlist);
 
     /* Extension editor dialog stuff */

diff --git a/src/extension/implementation/implementation.cpp b/src/extension/implementation/implementation.cpp
index e28dbcba6b74cb0216fb394e1ce7d0072d5f3dcc..6a9a7955f2a7a75a9565560d1d8e2c8820bd66b9 100644 (file)
--- a/src/extension/implementation/implementation.cpp
+++ b/src/extension/implementation/implementation.cpp
@@ -72,7 +72,7 @@ Implementation::save(Inkscape::Extension::Output *module, SPDocument *doc, gchar
 } /* Implementation::save */
 
 Gtk::Widget *
-Implementation::prefs_effect(Inkscape::Extension::Effect *module, Inkscape::UI::View::View *view, Glib::SignalProxy0<void> * changeSignal) {
+Implementation::prefs_effect(Inkscape::Extension::Effect *module, Inkscape::UI::View::View *view, sigc::signal<void> * changeSignal) {
     return module->autogui(NULL, NULL);
 } /* Implementation::prefs_effect */
 

diff --git a/src/extension/implementation/implementation.h b/src/extension/implementation/implementation.h
index cfffecad9b757146504ee163df0225eec6975a56..a132996f739faa2b4500f18aa8725efe970ee768 100644 (file)
--- a/src/extension/implementation/implementation.h
+++ b/src/extension/implementation/implementation.h
@@ -63,7 +63,7 @@ public:
 
     /* ----- Effect functions ----- */
     /** Find out information about the file. */
-    virtual Gtk::Widget * prefs_effect(Inkscape::Extension::Effect *module, Inkscape::UI::View::View * view, Glib::SignalProxy0<void> * changeSignal);
+    virtual Gtk::Widget * prefs_effect(Inkscape::Extension::Effect *module, Inkscape::UI::View::View * view, sigc::signal<void> * changeSignal);
     /* TODO: need to figure out what we need here */
 
     virtual void effect(Inkscape::Extension::Effect *module,

diff --git a/src/extension/implementation/script.cpp b/src/extension/implementation/script.cpp
index 857c36bc35d784386d32e6e36b0a1ee60ffef53f..96c436dfd0766f6bc5799c348369740cd443df4d 100644 (file)
--- a/src/extension/implementation/script.cpp
+++ b/src/extension/implementation/script.cpp
@@ -550,7 +550,7 @@ Script::prefs_output(Inkscape::Extension::Output *module)
 Gtk::Widget *
 Script::prefs_effect(Inkscape::Extension::Effect *module,
                      Inkscape::UI::View::View *view,
-                     Glib::SignalProxy0<void> * changeSignal)
+                     sigc::signal<void> * changeSignal)
 {
     SPDocument * current_document = view->doc();
 

diff --git a/src/extension/implementation/script.h b/src/extension/implementation/script.h
index 155abf7354748628dd2eb247a4da164a140aa65b..d8970cf15ac518ea2d584d6e620c443c7ae4e4cd 100644 (file)
--- a/src/extension/implementation/script.h
+++ b/src/extension/implementation/script.h
@@ -90,7 +90,7 @@ public:
      */
     virtual Gtk::Widget *prefs_effect(Inkscape::Extension::Effect *module,
                                       Inkscape::UI::View::View * view,
-                                      Glib::SignalProxy0<void> * changeSignal);
+                                      sigc::signal<void> * changeSignal);
 
     /**
      *

diff --git a/src/extension/internal/bluredge.cpp b/src/extension/internal/bluredge.cpp
index 248cf1c7dccedd91109ee173ce458c8ea036975b..aa1f3ece3fa29852248e95473bd153a6e75fe63d 100644 (file)
--- a/src/extension/internal/bluredge.cpp
+++ b/src/extension/internal/bluredge.cpp
@@ -117,7 +117,7 @@ BlurEdge::effect (Inkscape::Extension::Effect *module, Inkscape::UI::View::View
 }
 
 Gtk::Widget *
-BlurEdge::prefs_effect(Inkscape::Extension::Effect * module, Inkscape::UI::View::View * view, Glib::SignalProxy0<void> * changeSignal)
+BlurEdge::prefs_effect(Inkscape::Extension::Effect * module, Inkscape::UI::View::View * view, sigc::signal<void> * changeSignal)
 {
     return module->autogui(NULL, NULL, changeSignal);
 }

diff --git a/src/extension/internal/bluredge.h b/src/extension/internal/bluredge.h
index c84d16e96f74767ead1d4e65ac10fb240879d413..d97e73c9a682b1de1b221f707a2c33e3242b5add 100644 (file)
--- a/src/extension/internal/bluredge.h
+++ b/src/extension/internal/bluredge.h
@@ -22,7 +22,7 @@ class BlurEdge : public Inkscape::Extension::Implementation::Implementation {
 public:
     bool load(Inkscape::Extension::Extension *module);
     void effect(Inkscape::Extension::Effect *module, Inkscape::UI::View::View *document);
-    Gtk::Widget * prefs_effect(Inkscape::Extension::Effect * module, Inkscape::UI::View::View * view, Glib::SignalProxy0<void> * changeSignal);
+    Gtk::Widget * prefs_effect(Inkscape::Extension::Effect * module, Inkscape::UI::View::View * view, sigc::signal<void> * changeSignal);
 
     static void init (void);
 };

diff --git a/src/extension/internal/grid.cpp b/src/extension/internal/grid.cpp
index 0992681766e9b38320d51251cc432e892356ae53..1957813e5cf53cc6fbe9e2b0c3f2afcdc9c454d9 100644 (file)
--- a/src/extension/internal/grid.cpp
+++ b/src/extension/internal/grid.cpp
@@ -169,7 +169,7 @@ PrefAdjustment::val_changed (void)
     Uses AutoGUI for creating the GUI.
 */
 Gtk::Widget *
-Grid::prefs_effect(Inkscape::Extension::Effect *module, Inkscape::UI::View::View * view, Glib::SignalProxy0<void> * changeSignal)
+Grid::prefs_effect(Inkscape::Extension::Effect *module, Inkscape::UI::View::View * view, sigc::signal<void> * changeSignal)
 {
     SPDocument * current_document = view->doc();
 

diff --git a/src/extension/internal/grid.h b/src/extension/internal/grid.h
index 1fedbb177f5e00683aff69bf2b31ad9fb4028546..c4a97aeba4a279e4b3bdfb8262db28596ef61c10 100644 (file)
--- a/src/extension/internal/grid.h
+++ b/src/extension/internal/grid.h
@@ -22,7 +22,7 @@ class Grid : public Inkscape::Extension::Implementation::Implementation {
 public:
     bool load(Inkscape::Extension::Extension *module);
     void effect(Inkscape::Extension::Effect *module, Inkscape::UI::View::View *document);
-    Gtk::Widget * prefs_effect(Inkscape::Extension::Effect *module, Inkscape::UI::View::View * view, Glib::SignalProxy0<void> * changeSignal);
+    Gtk::Widget * prefs_effect(Inkscape::Extension::Effect *module, Inkscape::UI::View::View * view, sigc::signal<void> * changeSignal);
 
     static void init (void);
 };