summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: c6951dd)
raw | patch | inline | side by side (parent: c6951dd)
author | Shawn O. Pearce <spearce@spearce.org> | |
Mon, 20 Aug 2007 06:17:05 +0000 (02:17 -0400) | ||
committer | Shawn O. Pearce <spearce@spearce.org> | |
Mon, 20 Aug 2007 06:17:05 +0000 (02:17 -0400) |
Earlier when I rewrote the merge implementation for git-gui I broke
it such that the conflict markers for the "theirs" side of the hunk
was using a full SHA-1 ID in hex, rather than the name of the branch
the user had merged. This was because I got paranoid and passed off
the full SHA-1 to git-merge, instead of giving it the reference name
the user saw in the merge dialog.
I'd still like to resolve the SHA-1 upfront in git-gui and always use
that value throughout the merge, but I can't do that until we have a
full implementation of git-merge written in Tcl. Until then its more
important that the conflict markers be useful to the end-user, so we
need to pass off the ref name and not the SHA-1 ID.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
it such that the conflict markers for the "theirs" side of the hunk
was using a full SHA-1 ID in hex, rather than the name of the branch
the user had merged. This was because I got paranoid and passed off
the full SHA-1 to git-merge, instead of giving it the reference name
the user saw in the merge dialog.
I'd still like to resolve the SHA-1 upfront in git-gui and always use
that value throughout the merge, but I can't do that until we have a
full implementation of git-merge written in Tcl. Until then its more
important that the conflict markers be useful to the end-user, so we
need to pass off the ref name and not the SHA-1 ID.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
lib/merge.tcl | patch | blob | history |
diff --git a/lib/merge.tcl b/lib/merge.tcl
index 5de0d82b1486ef6ff8ce0eaea4221fa393a87d5b..0e50919d4c272e1e071e08c58b30d2c688c8d111 100644 (file)
--- a/lib/merge.tcl
+++ b/lib/merge.tcl
lappend cmd --strategy=recursive
lappend cmd [git fmt-merge-msg <[gitdir FETCH_HEAD]]
lappend cmd HEAD
- lappend cmd $cmit
+ lappend cmd $name
set msg "Merging $current_branch and $stitle"
ui_status "$msg..."