Fixed buffer overflow in check_ntp/check_ntp_peer (#1999319, Ubuntu #291265)

git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2086 f882894a-f735-0410-b71e-b25c423dba1c

diff --git a/NEWS b/NEWS
index 5149f913a8a8ec5ca53554c5046edbb7c30f5511..c69fd2f808a30ba39569124c024ef51dca0c18f9 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -16,6 +16,7 @@ This file documents the major additions and syntax changes between releases.
        check_icmp now reports min and max round trip time perfdata (Steve Rader)
        Fixed bug where additional headers with redirection caused a segfault (Dieter Van de Walle - 2089159)
        check_disk: make autofs mount paths specified with -p before we determing the mount list (Erik Welch)
+       Fixed buffer overflow in check_ntp/check_ntp_peer (#1999319, Ubuntu #291265)
 
 1.4.13 25th Sept 2008
        Fix Debian bug #460097: check_http --max-age broken (Hilko Bengen)

diff --git a/plugins/check_ntp.c b/plugins/check_ntp.c
index 68c82d1154655907b4b7e8df8221d8b1de1e2594..489ad60aafb5016108bc8a986f432e8c8668d5ed 100644 (file)
--- a/plugins/check_ntp.c
+++ b/plugins/check_ntp.c
@@ -198,7 +198,7 @@ typedef struct {
 /* NTP control message header is 12 bytes, plus any data in the data
  * field, plus null padding to the nearest 32-bit boundary per rfc.
  */
-#define SIZEOF_NTPCM(m) (12+ntohs(m.count)+((m.count)?4-(ntohs(m.count)%4):0))
+#define SIZEOF_NTPCM(m) (12+ntohs(m.count)+((ntohs(m.count)%4)?4-(ntohs(m.count)%4):0))
 
 /* finally, a little helper or two for debugging: */
 #define DBG(x) do{if(verbose>1){ x; }}while(0);

diff --git a/plugins/check_ntp_peer.c b/plugins/check_ntp_peer.c
index 3add27376c05bfcc940778a7f24db265f3dd57ed..e489a5803464eee3e16755e2c161250648629be0 100644 (file)
--- a/plugins/check_ntp_peer.c
+++ b/plugins/check_ntp_peer.c
@@ -131,7 +131,7 @@ typedef struct {
 /* NTP control message header is 12 bytes, plus any data in the data
  * field, plus null padding to the nearest 32-bit boundary per rfc.
  */
-#define SIZEOF_NTPCM(m) (12+ntohs(m.count)+((m.count)?4-(ntohs(m.count)%4):0))
+#define SIZEOF_NTPCM(m) (12+ntohs(m.count)+((ntohs(m.count)%4)?4-(ntohs(m.count)%4):0))
 
 /* finally, a little helper or two for debugging: */
 #define DBG(x) do{if(verbose>1){ x; }}while(0);