Code

gitweb: escape tag comments
authorDaniel Drake <dsd@gentoo.org>
Mon, 24 Jul 2006 22:07:23 +0000 (23:07 +0100)
committerJunio C Hamano <junkio@cox.net>
Tue, 25 Jul 2006 21:05:55 +0000 (14:05 -0700)
I have a tag with a comment which includes an & character. Firefox wouldn't
display my gitweb summary page due to malformed XML. This solves the problem.

Signed-off-by: Daniel Drake <dsd@gentoo.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
gitweb/gitweb.cgi

index 2fd1e5f78ec8c2eb743c54cc0281821958141ce4..5acd66dd6c81332e114cb85df73671ead6fc6955 100755 (executable)
@@ -1138,7 +1138,7 @@ sub git_summary {
                                      "</td>\n" .
                                      "<td>";
                                if (defined($comment)) {
-                                     print $cgi->a({-class => "list", -href => "$my_uri?" . esc_param("p=$project;a=tag;h=$tag{'id'}")}, $comment);
+                                     print $cgi->a({-class => "list", -href => "$my_uri?" . esc_param("p=$project;a=tag;h=$tag{'id'}")}, esc_html($comment));
                                }
                                print "</td>\n" .
                                      "<td class=\"link\">";