gitk: Wait for the window to become visible after creating it

When the git log process returned an error immediately, we were
sometimes getting no main window and no error window displayed,
with the gitk process just hanging waiting for something.  It appears
that the tkwait in show_error, which waits for the error window to
be destroyed, wasn't sufficient to allow the main window or the error
window to be mapped.

This adds a wait in the main startup code after the main window
has been created to wait until it is visible.  This seems to fix the
problem.

Signed-off-by: Paul Mackerras <paulus@samba.org>

diff --git a/gitk b/gitk
index 66e4a643d6df64ad42c5d6a68e9c75eaf2f591a8..5cfb1cc391bad62f81e52bcd35ef4e1b2ad759cc 100755 (executable)
--- a/gitk
+++ b/gitk
@@ -7646,6 +7646,8 @@ set localfrow -1
 set lserial 0
 setcoords
 makewindow
+# wait for the window to become visible
+tkwait visibility .
 wm title . "[file tail $argv0]: [file tail [pwd]]"
 readrefs