Code

git-clone: quote destination directory name
authorPavel Roskin <proski@gnu.org>
Fri, 11 Nov 2005 05:19:04 +0000 (00:19 -0500)
committerJunio C Hamano <junkio@cox.net>
Fri, 11 Nov 2005 09:15:00 +0000 (01:15 -0800)
git-clone doesn't quote the full path to the destination directory,
which causes it to fail if the path contains spaces or other characters
interpreted by the shell.

[jc: obviously I was not careful enough.  Pavel, thanks for catching.]

Signed-off-by: Pavel Roskin <proski@gnu.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
git-clone.sh

index aafcc18abafb8befd82165587cc9142ed42eb009..f5ef70b8afa792671f5aa6e4dd752e63c376c6dd 100755 (executable)
@@ -163,7 +163,7 @@ yes,yes)
                        rm -f "$D/.git/TMP_ALT"
                if test -f "$D/.git/TMP_ALT"
                then
-                   ( cd $D &&
+                   ( cd "$D" &&
                      . git-parse-remote &&
                      resolve_alternates "$repo" <"./.git/TMP_ALT" ) |
                    while read alt
@@ -191,7 +191,7 @@ yes,yes)
        ;;
 esac
 
-cd $D || exit
+cd "$D" || exit
 
 if test -f ".git/HEAD"
 then