Code

avoid echo -e, there are systems where it does not work
authorAlex Riesen <raa.lkml@gmail.com>
Sun, 12 Feb 2006 18:05:34 +0000 (19:05 +0100)
committerJunio C Hamano <junkio@cox.net>
Sun, 12 Feb 2006 19:36:19 +0000 (11:36 -0800)
FreeBSD 4.11 being one example: the built-in echo doesn't have -e,
and the installed /bin/echo does not do "-e" as well.
"printf" works, laking just "\e" and "\xAB'.

Signed-off-by: Junio C Hamano <junkio@cox.net>
git-tag.sh
t/t3001-ls-files-others-exclude.sh

index 6d0c973239a1b72bbef43aa430f1ee534b7ab458..c74e1b4151a3d05a5825dc7dcba2dfaf1ad9a0fa 100755 (executable)
@@ -85,7 +85,8 @@ if [ "$annotate" ]; then
        exit 1
     }
 
-    ( echo -e "object $object\ntype $type\ntag $name\ntagger $tagger\n";
+    ( printf 'object %s\ntype %s\ntag %s\ntagger %s\n\n' \
+       "$object" "$type" "$name" "$tagger";
       cat "$GIT_DIR"/TAG_FINALMSG ) >"$GIT_DIR"/TAG_TMP
     rm -f "$GIT_DIR"/TAG_TMP.asc "$GIT_DIR"/TAG_FINALMSG
     if [ "$signed" ]; then
index fde2bb25fa0fb41c09b4e4c87de8b9d1c0f9c237..6979b7c1c05001d08ce94f9034580f94745b4924 100755 (executable)
@@ -68,7 +68,7 @@ test_expect_success \
      diff -u expect output'
 
 # Test \r\n (MSDOS-like systems)
-echo -ne '*.1\r\n/*.3\r\n!*.6\r\n' >.gitignore
+printf '*.1\r\n/*.3\r\n!*.6\r\n' >.gitignore
 
 test_expect_success \
     'git-ls-files --others with \r\n line endings.' \