author | Junio C Hamano <gitster@pobox.com> | |
Fri, 27 Feb 2009 09:03:21 +0000 (01:03 -0800) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Fri, 27 Feb 2009 09:03:21 +0000 (01:03 -0800) |
* cc/maint-1.6.0-bisect-fix:
bisect: fix quoting TRIED revs when "bad" commit is also "skip"ped
Conflicts:
git-bisect.sh
bisect: fix quoting TRIED revs when "bad" commit is also "skip"ped
Conflicts:
git-bisect.sh
1 | 2 | |||
---|---|---|---|---|
git-bisect.sh | patch | | diff1 | | diff2 | | blob | history |
t/t6030-bisect-porcelain.sh | patch | | diff1 | | diff2 | | blob | history |
diff --cc git-bisect.sh
index 85db4ba40022e3a9e5790879d6d21fa59475b316,f9a5c0bdf4382c09a978ce42b013c507c0fb1e0c..a857db447ceaf293f6e4ddad3c9038e18b96c0ca
--- 1/git-bisect.sh
--- 2/git-bisect.sh
+++ b/git-bisect.sh
# Let's parse the output of:
# "git rev-list --bisect-vars --bisect-all ..."
- eval "$_eval" | while read hash line
- do
- case "$VARS,$FOUND,$TRIED,$hash" in
- # We display some vars.
- 1,*,*,*) echo "$hash $line" ;;
-
- # Split line.
- ,*,*,---*) ;;
-
- # We had nothing to search.
- eval_rev_list "$_eval" | {
++ eval "$_eval" | {
+ VARS= FOUND= TRIED=
+ while read hash line
+ do
+ case "$VARS,$FOUND,$TRIED,$hash" in
+ 1,*,*,*)
+ # "bisect_foo=bar" read from rev-list output.
+ echo "$hash &&"
+ ;;
+ ,*,*,---*)
+ # Separator
+ ;;
,,,bisect_rev*)
- echo "bisect_rev="
+ # We had nothing to search.
+ echo "bisect_rev= &&"
VARS=1
;;
-
- # We did not find a good bisect rev.
- # This should happen only if the "bad"
- # commit is also a "skip" commit.
,,*,bisect_rev*)
- echo "bisect_rev=$TRIED"
+ # We did not find a good bisect rev.
+ # This should happen only if the "bad"
+ # commit is also a "skip" commit.
+ echo "bisect_rev='$TRIED' &&"
VARS=1
;;
-
- # We are searching.
,,*,*)
+ # We are searching.
TRIED="${TRIED:+$TRIED|}$hash"
case "$_skip" in
*$hash*) ;;
diff --cc t/t6030-bisect-porcelain.sh
Simple merge