summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: ae7706b)
raw | patch | inline | side by side (parent: ae7706b)
author | Ramsay Jones <ramsay@ramsay1.demon.co.uk> | |
Mon, 13 Feb 2012 18:24:41 +0000 (18:24 +0000) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Mon, 13 Feb 2012 19:12:36 +0000 (11:12 -0800) |
In particular, sparse complains as follows:
SP builtin/tag.c
builtin/tag.c:411:5: warning: symbol 'parse_opt_points_at' was \
not declared. Should it be static?
In order to suppress the warning, since the parse_opt_points_at()
function does not need to be an external symbol, we simply add the
static modifier to the function definition.
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
SP builtin/tag.c
builtin/tag.c:411:5: warning: symbol 'parse_opt_points_at' was \
not declared. Should it be static?
In order to suppress the warning, since the parse_opt_points_at()
function does not need to be an external symbol, we simply add the
static modifier to the function definition.
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/tag.c | patch | blob | history |
diff --git a/builtin/tag.c b/builtin/tag.c
index 27c35571abbd57b95153361b97ae1c1b951793ca..e377706e6d362792055b5e2a67efc12edd972e52 100644 (file)
--- a/builtin/tag.c
+++ b/builtin/tag.c
return check_refname_format(sb->buf, 0);
}
-int parse_opt_points_at(const struct option *opt __attribute__ ((unused)),
+static int parse_opt_points_at(const struct option *opt __attribute__((unused)),
const char *arg, int unset)
{
unsigned char sha1[20];