Code

Remove a CURLOPT_HTTPHEADER (un)setting
authorMike Hommey <mh@glandium.org>
Mon, 10 Dec 2007 21:36:08 +0000 (22:36 +0100)
committerJunio C Hamano <gitster@pobox.com>
Sat, 15 Dec 2007 05:31:59 +0000 (21:31 -0800)
Setting CURLOPT_HTTPHEADER doesn't add HTTP headers, but replaces whatever
set of headers was configured before, so setting to NULL doesn't have any
magic meaning, and is pretty much useless when setting to another list
right after.

Signed-off-by: Mike Hommey <mh@glandium.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
http.c

diff --git a/http.c b/http.c
index 146f62609dbf75cf8b6d873f040e1386d73b57d1..ae57073a362ef7bc373855a132b9c25b3e60c154 100644 (file)
--- a/http.c
+++ b/http.c
@@ -370,7 +370,6 @@ struct active_request_slot *get_active_slot(void)
        slot->finished = NULL;
        slot->callback_data = NULL;
        slot->callback_func = NULL;
-       curl_easy_setopt(slot->curl, CURLOPT_HTTPHEADER, NULL);
        curl_easy_setopt(slot->curl, CURLOPT_HTTPHEADER, pragma_header);
        curl_easy_setopt(slot->curl, CURLOPT_ERRORBUFFER, curl_errorstr);
        curl_easy_setopt(slot->curl, CURLOPT_CUSTOMREQUEST, NULL);