Code

git-submodule: move ill placed shift.
authorPierre Habouzit <madcoder@debian.org>
Mon, 21 Jul 2008 18:15:59 +0000 (20:15 +0200)
committerJunio C Hamano <gitster@pobox.com>
Sat, 2 Aug 2008 06:16:38 +0000 (23:16 -0700)
When running git submodule update -i, the "-i" is shifted before recursing
into cmd_init and then again outside of the loop. This causes some /bin/sh
to complain about shifting when there are no arguments left (and would
discard anything written after -i too).

Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
git-submodule.sh

index 099a7d7560879c284c9fb2fff68f4588baaaf49b..21e5b5b7daf341a59b9496b235adcceafe4f2c8c 100755 (executable)
@@ -269,6 +269,7 @@ cmd_update()
        do
                case "$1" in
                -q|--quiet)
+                       shift
                        quiet=1
                        ;;
                -i|--init)
@@ -286,7 +287,6 @@ cmd_update()
                        break
                        ;;
                esac
-               shift
        done
 
        git ls-files --stage -- "$@" | grep '^160000 ' |