author | Jakub Narebski <jnareb@gmail.com> | |
Thu, 5 Jan 2012 20:26:48 +0000 (21:26 +0100) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Thu, 5 Jan 2012 21:29:50 +0000 (13:29 -0800) | ||
commit | ff7f2185d6e04b7bea66f39ee51d79919ab1279c | |
tree | 1672acd00b0d276490c53966ee0e58e44b9d8029 | tree | snapshot |
parent | 1327d83954bcf755094995b63317b23986c550f2 | commit | diff |
gitweb: Fix file links in "grep" search
There were two bugs in generating file links (links to "blob" view),
one hidden by the other. The correct way of generating file link is
href(action=>"blob", hash_base=>$co{'id'},
file_name=>$file);
It was $co{'hash'} (this key does not exist, and therefore this is
undef), and 'hash' instead of 'hash_base'.
To have this fix applied in single place, this commit also reduces
code duplication by saving file link (which is used for line links) in
$file_href.
Reported-by: Thomas Perl <th.perl@gmail.com>
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
There were two bugs in generating file links (links to "blob" view),
one hidden by the other. The correct way of generating file link is
href(action=>"blob", hash_base=>$co{'id'},
file_name=>$file);
It was $co{'hash'} (this key does not exist, and therefore this is
undef), and 'hash' instead of 'hash_base'.
To have this fix applied in single place, this commit also reduces
code duplication by saving file link (which is used for line links) in
$file_href.
Reported-by: Thomas Perl <th.perl@gmail.com>
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
gitweb/gitweb.perl | diff | blob | history |