author | Johannes Schindelin <Johannes.Schindelin@gmx.de> | |
Tue, 11 Mar 2008 09:56:30 +0000 (10:56 +0100) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Wed, 12 Mar 2008 02:57:56 +0000 (19:57 -0700) | ||
commit | fc99469a2b786676ffe48d5966d71cea3613b716 | |
tree | 028afe90d4f8331a37f82b42169cbefd98f2ec9b | tree | snapshot |
parent | 4201bb5f7e408143dc5bf35497cc82bc803fe9fb | commit | diff |
launch_editor(): allow spaces in the filename
The construct
sh -c "$0 \"$@\"" <editor> <file>
does not pick up quotes in <editor>, so you cannot give path to the
editor that has a shell IFS whitespace in it, and also give it initial
set of parameters and flags. Replace $0 with <editor> to fix this issue.
This fixes
git config core.editor '"c:/Program Files/What/Ever.exe"'
In other words, you can specify an editor with spaces in its path using a
config containing something like this:
[core]
editor = \"c:/Program Files/Darn/Spaces.exe\"
NOTE: we cannot just replace the $0 with \"$0\", because we still want
this to work:
[core]
editor = emacs -nw
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The construct
sh -c "$0 \"$@\"" <editor> <file>
does not pick up quotes in <editor>, so you cannot give path to the
editor that has a shell IFS whitespace in it, and also give it initial
set of parameters and flags. Replace $0 with <editor> to fix this issue.
This fixes
git config core.editor '"c:/Program Files/What/Ever.exe"'
In other words, you can specify an editor with spaces in its path using a
config containing something like this:
[core]
editor = \"c:/Program Files/Darn/Spaces.exe\"
NOTE: we cannot just replace the $0 with \"$0\", because we still want
this to work:
[core]
editor = emacs -nw
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin-tag.c | diff | blob | history | |
t/t7005-editor.sh | diff | blob | history |