author | Jim Meyering <jim@meyering.net> | |
Thu, 25 May 2006 16:52:01 +0000 (18:52 +0200) | ||
committer | Junio C Hamano <junkio@cox.net> | |
Fri, 26 May 2006 05:57:06 +0000 (22:57 -0700) | ||
commit | fc36f6a6c9e6d428dafee47f140f943b3e520240 | |
tree | 37e0ecb362e3f640b4d917883df5189870d81a06 | tree | snapshot |
parent | 4d599e6bb46d6ef3276425af34922fdbf3aac473 | commit | diff |
Don't write directly to a make target ($@).
Otherwise, if make is suspended, or killed with prejudice, or if the
system crashes, you could be left with an up-to-date, yet corrupt,
generated file.
I left off the `clean' addition, because I believe "make clean" should
not remove wildcard patterns like "*+", on the off-chance that someone
uses names like that for files they care about. Besides, in practice,
those temporary files are left behind so rarely that they're not a bother,
and they're removed again as part of the next build.
[jc: sign-off?]
Signed-off-by: Junio C Hamano <junkio@cox.net>
Otherwise, if make is suspended, or killed with prejudice, or if the
system crashes, you could be left with an up-to-date, yet corrupt,
generated file.
I left off the `clean' addition, because I believe "make clean" should
not remove wildcard patterns like "*+", on the off-chance that someone
uses names like that for files they care about. Besides, in practice,
those temporary files are left behind so rarely that they're not a bother,
and they're removed again as part of the next build.
[jc: sign-off?]
Signed-off-by: Junio C Hamano <junkio@cox.net>
Makefile | diff | blob | history |