![[tokkee]](http://tokkee.org/images/avatar.png){kind=avatar}
| author | Markus Heidelberg <markus.heidelberg@web.de> | |
| Fri, 12 Jun 2009 10:51:41 +0000 (12:51 +0200) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 12 Jun 2009 16:22:15 +0000 (09:22 -0700) | ||
| commit | f74fe34b96816bad1f568202ec51ef18ae7513b3 | |
| tree | 7c612429c17ff4f8a76a0b4421fb475ff0c7a4fc | tree | snapshot |
| parent | d67114a5f3cbbedd4f01e6ff87fd5d4db9563ead | commit | diff |
send-email: fix threaded mails without chain-reply-to
An earlier commit 15da108 ("send-email: 'References:' should only
reference what is sent", 2009-04-13) broke logic to set up threading
information for the next message by rewriting "!" to "not" without
understanding the precedence rules of the language.
Namely,
! defined $reply_to || length($reply_to) == 0
was changed to
not defined $reply_to || length($reply_to) == 0
which is
not (defined $reply_to || length($reply_to) == 0)
and different from what was intended, which is
(not defined $reply_to) || (length($reply_to) == 0)
Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
An earlier commit 15da108 ("send-email: 'References:' should only
reference what is sent", 2009-04-13) broke logic to set up threading
information for the next message by rewriting "!" to "not" without
understanding the precedence rules of the language.
Namely,
! defined $reply_to || length($reply_to) == 0
was changed to
not defined $reply_to || length($reply_to) == 0
which is
not (defined $reply_to || length($reply_to) == 0)
and different from what was intended, which is
(not defined $reply_to) || (length($reply_to) == 0)
Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| git-send-email.perl | diff | blob | history | |
| t/t9001-send-email.sh | diff | blob | history |