Code

Fix tests breaking when checkout path contains shell metacharacters
authorBryan Donlan <bdonlan@fushizen.net>
Sun, 4 May 2008 05:37:59 +0000 (01:37 -0400)
committerJunio C Hamano <gitster@pobox.com>
Mon, 5 May 2008 21:37:02 +0000 (14:37 -0700)
commitf69e836fab2b634281d92a0d304de4d768e479cc
treeebd3e28ff26f0077846085d5c86970cc5ee05759
parent0e46e704626af5189c9c9ff2c0f348d2205c10f3
Fix tests breaking when checkout path contains shell metacharacters

This fixes the remainder of the issues where the test script itself is at
fault for failing when the git checkout path contains whitespace or other
shell metacharacters.

The majority of git svn tests used the idiom

  test_expect_success "title" "test script using $svnrepo"

These were changed to have the test script in single-quotes:

  test_expect_success "title" 'test script using "$svnrepo"'

which unfortunately makes the patch appear larger than it really is.

One consequence of this change is that in the verbose test output the
value of $svnrepo (and in some cases other variables, too) is no
longer expanded, i.e. previously we saw

  * expecting success:
test script using /path/to/git/t/trash/svnrepo

but now it is:

  * expecting success:
test script using "$svnrepo"

Signed-off-by: Bryan Donlan <bdonlan@fushizen.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
39 files changed:
t/t0000-basic.sh
t/t1020-subdirectory.sh
t/t3050-subprojects-fetch.sh
t/t3404-rebase-interactive.sh
t/t5500-fetch-pack.sh
t/t5512-ls-remote.sh
t/t5516-fetch-push.sh
t/t5700-clone-reference.sh
t/t5710-info-alternate.sh
t/t7003-filter-branch.sh
t/t7010-setup.sh
t/t7300-clean.sh
t/t7501-commit.sh
t/t7504-commit-msg-hook.sh
t/t7505-prepare-commit-msg-hook.sh
t/t9100-git-svn-basic.sh
t/t9101-git-svn-props.sh
t/t9102-git-svn-deep-rmdir.sh
t/t9103-git-svn-tracked-directory-removed.sh
t/t9104-git-svn-follow-parent.sh
t/t9105-git-svn-commit-diff.sh
t/t9106-git-svn-commit-diff-clobber.sh
t/t9106-git-svn-dcommit-clobber-series.sh
t/t9107-git-svn-migrate.sh
t/t9108-git-svn-glob.sh
t/t9110-git-svn-use-svm-props.sh
t/t9111-git-svn-use-svnsync-props.sh
t/t9112-git-svn-md5less-file.sh
t/t9113-git-svn-dcommit-new-file.sh
t/t9114-git-svn-dcommit-merge.sh
t/t9115-git-svn-dcommit-funky-renames.sh
t/t9116-git-svn-log.sh
t/t9117-git-svn-init-clone.sh
t/t9118-git-svn-funky-branch-names.sh
t/t9120-git-svn-clone-with-percent-escapes.sh
t/t9121-git-svn-fetch-renamed-dir.sh
t/t9400-git-cvsserver-server.sh
t/t9500-gitweb-standalone-no-errors.sh
t/t9600-cvsimport.sh