author | Clemens Buchacher <drizzd@aon.at> | |
Mon, 13 Feb 2012 20:17:12 +0000 (21:17 +0100) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Mon, 13 Feb 2012 21:29:08 +0000 (13:29 -0800) | ||
commit | ef7e93d90866e91bba5ff7f274c49dc44427a8ff | |
tree | 5288d54312763c623686edebd736d4da7a7f7825 | tree | snapshot |
parent | d0482e88a735787f7bb33ef4783be0e7f6a70946 | commit | diff |
do not override receive-pack errors
Receive runs rev-list --verify-objects in order to detect missing
objects. However, such errors are ignored and overridden later.
Instead, consequently ignore all update commands for which an error has
already been detected.
Some tests in t5504 are obsoleted by this change, because invalid
objects are detected even if fsck is not enabled. Instead, they now test
for different error messages depending on whether or not fsck is turned
on. A better fix would be to force a corruption that will be detected by
fsck but not by rev-list.
Signed-off-by: Clemens Buchacher <drizzd@aon.at>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Receive runs rev-list --verify-objects in order to detect missing
objects. However, such errors are ignored and overridden later.
Instead, consequently ignore all update commands for which an error has
already been detected.
Some tests in t5504 are obsoleted by this change, because invalid
objects are detected even if fsck is not enabled. Instead, they now test
for different error messages depending on whether or not fsck is turned
on. A better fix would be to force a corruption that will be detected by
fsck but not by rev-list.
Signed-off-by: Clemens Buchacher <drizzd@aon.at>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/receive-pack.c | diff | blob | history | |
t/t5504-fetch-receive-strict.sh | diff | blob | history |