Code

http-push: refactor curl_easy_setup madness
authorDan McGee <dpmcgee@gmail.com>
Tue, 3 May 2011 15:47:29 +0000 (23:47 +0800)
committerJunio C Hamano <gitster@pobox.com>
Wed, 4 May 2011 20:30:28 +0000 (13:30 -0700)
commitebaaf316ca5b7317a945a1590e8dab4e39932fbb
tree372274a636334f062fb280c7911120da0521be0c
parent2aab167adfe920bf641a3ad77be1854a8eaefe46
http-push: refactor curl_easy_setup madness

We were doing (nearly) the same thing all over the place, in slightly
different orders, different variable names, etc. Refactor most calls
into two helper functions, one for GET and one for everything else, that
do the heavy lifting leaving most callsites a lot cleaner in the
process.

Note that the setting of CURLOPT_PUT at the callsites of
curl_setup_http() which previously didn't do it (eg.
locking_available(), remote_ls()) is safe, since that
option is deprecated in libcurl in place of, and has the same effect as,
CURLOPT_UPLOAD.

Signed-off-by: Dan McGee <dpmcgee@gmail.com>
Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
http-push.c