author | Junio C Hamano <gitster@pobox.com> | |
Mon, 14 Jan 2008 21:54:24 +0000 (13:54 -0800) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Mon, 14 Jan 2008 21:54:24 +0000 (13:54 -0800) | ||
commit | e87e22d0f22eb262a90e76197465d6cfd9707ea1 | |
tree | 1803e67ec3c5e8bfcfdd59e97bcb982d43e6d518 | tree | snapshot |
parent | c60b528225d2827fd43d4fe4b082e0188df7a280 | commit | diff |
Revert "builtin-commit.c: remove useless check added by faulty cut and paste"
This reverts commit 16335fdd7ace78a8285ba25fd7a81177a48e7c9b.
We are calling overlay_tree_on_cache() which does use CE_UPDATE
flag to mark duplicated entries, which is the same as the
codepath in git-ls-files with its --with-tree option.
Because the pathname ce->name is given to path_list_insert()
which does not allow duplicates, there is no breakage either way
from the correctness point of view in this codepath, unlike the
one in ls-files. But avoiding unnecessary processing with a
single bit check is certainly better.
This reverts commit 16335fdd7ace78a8285ba25fd7a81177a48e7c9b.
We are calling overlay_tree_on_cache() which does use CE_UPDATE
flag to mark duplicated entries, which is the same as the
codepath in git-ls-files with its --with-tree option.
Because the pathname ce->name is given to path_list_insert()
which does not allow duplicates, there is no breakage either way
from the correctness point of view in this codepath, unlike the
one in ls-files. But avoiding unnecessary processing with a
single bit check is certainly better.
builtin-commit.c | diff | blob | history |