![[tokkee]](http://tokkee.org/images/avatar.png){kind=avatar}
| author | Keith Cascio <keith@cs.ucla.edu> | |
| Tue, 17 Feb 2009 02:59:00 +0000 (18:59 -0800) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 4 Mar 2009 08:56:51 +0000 (00:56 -0800) | ||
| commit | e752f4bba24afe964eb42d6c2b8bf06cc77c9ce4 | |
| tree | df34d7093c4deb2db45569c964d54837fcf84dcc | tree | snapshot |
| parent | 628d5c2b707db207e47c42ca112b182aa171cfaa | commit | diff |
Fix neglect of diff_setup()/diff_setup_done() symmetry.
Code that calls diff_setup(), including via init_revisions(), should later call
diff_setup_done(), possibly via setup_revisions(). Failure to do so could cause
errors, especially in the future when we add responsibilities to
diff_setup_done(). This instance causes no known errors with the present code.
But it resulted in an error with an experimental patch.
Signed-off-by: Keith Cascio <keith@cs.ucla.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Code that calls diff_setup(), including via init_revisions(), should later call
diff_setup_done(), possibly via setup_revisions(). Failure to do so could cause
errors, especially in the future when we add responsibilities to
diff_setup_done(). This instance causes no known errors with the present code.
But it resulted in an error with an experimental patch.
Signed-off-by: Keith Cascio <keith@cs.ucla.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin-checkout.c | diff | blob | history |