author | jefromi <jefromi@gmail.com> | |
Wed, 4 Feb 2009 15:30:00 +0000 (16:30 +0100) | ||
committer | Max Kellermann <max@duempel.org> | |
Mon, 9 Feb 2009 16:00:17 +0000 (17:00 +0100) | ||
commit | e06ce8df076331c7a345627bab3e8a375f505fe1 | |
tree | 3fca4c3fc3d975f53eac4b4d5ca0d14a93670461 | tree | snapshot |
parent | bcb11a82d4ba42079c14333f9e0d395a4452e256 | commit | diff |
list_window: bell when searches wrap
NCMPC triggers a bell whenever a search wraps. (Note that this means a
double-bell whenever a wrapped search finds nothing.) I can see this
being reasonable, if the playlist is short and the user is aware of
which direction they want to search in. However if you predominantly
use long playlists and don't know which direction your target is in,
this means you get bells on half your searches.
Since I could see people wanting it either way, my best idea is making
the bell optional. Here's a patch to do that, defaulting to the
current behavior. (I'm a little confused about defaults - looks like
there are only default values for some in options.c - but it looks
like this behaves as desired.)
NCMPC triggers a bell whenever a search wraps. (Note that this means a
double-bell whenever a wrapped search finds nothing.) I can see this
being reasonable, if the playlist is short and the user is aware of
which direction they want to search in. However if you predominantly
use long playlists and don't know which direction your target is in,
this means you get bells on half your searches.
Since I could see people wanting it either way, my best idea is making
the bell optional. Here's a patch to do that, defaulting to the
current behavior. (I'm a little confused about defaults - looks like
there are only default values for some in options.c - but it looks
like this behaves as desired.)
src/conf.c | diff | blob | history | |
src/list_window.c | diff | blob | history | |
src/list_window.h | diff | blob | history | |
src/options.c | diff | blob | history | |
src/options.h | diff | blob | history | |
src/screen_utils.c | diff | blob | history |