author | Jeff King <peff@peff.net> | |
Fri, 14 Oct 2011 07:40:40 +0000 (09:40 +0200) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Sun, 16 Oct 2011 04:18:36 +0000 (21:18 -0700) | ||
commit | deba49377b717d1e26c342f65c7f5e75a2db8641 | |
tree | 2750a54dc827a61ec64d362a791b3936f6cf6e97 | tree | snapshot |
parent | 070b4dd5899927cb399b8ae9d75cad1fce537429 | commit | diff |
http_init: accept separate URL parameter
The http_init function takes a "struct remote". Part of its
initialization procedure is to look at the remote's url and
grab some auth-related parameters. However, using the url
included in the remote is:
- wrong; the remote-curl helper may have a separate,
unrelated URL (e.g., from remote.*.pushurl). Looking at
the remote's configured url is incorrect.
- incomplete; http-fetch doesn't have a remote, so passes
NULL. So http_init never gets to see the URL we are
actually going to use.
- cumbersome; http-push has a similar problem to
http-fetch, but actually builds a fake remote just to
pass in the URL.
Instead, let's just add a separate URL parameter to
http_init, and all three callsites can pass in the
appropriate information.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The http_init function takes a "struct remote". Part of its
initialization procedure is to look at the remote's url and
grab some auth-related parameters. However, using the url
included in the remote is:
- wrong; the remote-curl helper may have a separate,
unrelated URL (e.g., from remote.*.pushurl). Looking at
the remote's configured url is incorrect.
- incomplete; http-fetch doesn't have a remote, so passes
NULL. So http_init never gets to see the URL we are
actually going to use.
- cumbersome; http-push has a similar problem to
http-fetch, but actually builds a fake remote just to
pass in the URL.
Instead, let's just add a separate URL parameter to
http_init, and all three callsites can pass in the
appropriate information.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
http-fetch.c | diff | blob | history | |
http-push.c | diff | blob | history | |
http.c | diff | blob | history | |
http.h | diff | blob | history | |
remote-curl.c | diff | blob | history |